Simone Basso
8f18813e17
cli: upgrade to lucas-clemente/quic-go 0.23.0 ( #449 )
...
See https://github.com/ooni/probe/issues/1754 for a comprehensive description.
2021-08-23 16:49:22 +02:00
Simone Basso
ceb2aa8a8d
fix(netx): make sure we save quic udp conn events ( #423 )
...
https://github.com/ooni/probe-cli/pull/421 was wrong because we need
a more rich interface for quic-go to call ReadMsgUDP.
With this commit, we use such an interface: OOBCapablePacketConn.
Still part of https://github.com/ooni/probe/issues/1505 .
2021-07-02 11:00:12 +02:00
Simone Basso
250a595f89
refactor: cleaner way of passing a UDPConn around ( #421 )
...
* refactor: cleaner way of passing a UDPConn around
Also part of https://github.com/ooni/probe/issues/1505
* Update internal/engine/netx/quicdialer/connectionstate.go
2021-07-01 21:56:29 +02:00
Simone Basso
046dd4545d
feat(netxlite): add QUICDialerLogger ( #410 )
...
Part of https://github.com/ooni/probe/issues/1505
2021-06-26 16:54:02 +02:00
Simone Basso
b07890af4d
fix(netxlite): improve TLS auto-configuration ( #409 )
...
Auto-configure every relevant TLS field as close as possible to
where it's actually used.
As a side effect, add support for mocking the creation of a TLS
connection, which should possibly be useful for uTLS?
Work that is part of https://github.com/ooni/probe/issues/1505
2021-06-25 20:51:59 +02:00
Simone Basso
f1f5ed342e
refactor: move quic dns dialing to netxlite ( #408 )
...
Part of https://github.com/ooni/probe/issues/1505
2021-06-25 18:38:13 +02:00
Simone Basso
a4d61a4be4
fix(netxlite): close quic packetconn ( #407 )
...
Noticed when working on https://github.com/ooni/probe/issues/1505 .
Justification for this diff:
1. [DialEarlyContext calls dialContext with the last argument set to false](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L153 );
2. [the semantics of the last argument is whether we own the connection](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L187 );
3. [this value is propagated to the client data structure](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L269 );
4. [client.dial](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L302 ) runs the session in a background goroutine and only destroys the `packetHandlers` when the connection is owned;
5. [packetHandlerMap.Destroy](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/packet_handler_map.go#L293 ) closes the underlying PacketConn.
6. also, the documentation clearly states that when you use `DialEarlyContext` you can use the same packet conn multiple times, so it does not take ownership.
2021-06-25 17:58:42 +02:00
Simone Basso
925ca22b88
refactor: move quicdialing base functionality to netxlite ( #406 )
...
Part of https://github.com/ooni/probe/issues/1505
2021-06-25 17:04:24 +02:00
