Always include the country code and drop include_probe_cc setting

Fixes: https://github.com/ooni/probe/issues/1183
This commit is contained in:
Arturo Filastò
2020-06-02 18:40:55 +02:00
parent 0f38375c81
commit f2e62b7ad7
4 changed files with 2 additions and 20 deletions
-10
View File
@@ -76,13 +76,11 @@ func Onboarding(config *config.Config) error {
settings := struct {
IncludeIP bool
IncludeNetwork bool
IncludeCountry bool
UploadResults bool
SendCrashReports bool
}{}
settings.IncludeIP = false
settings.IncludeNetwork = true
settings.IncludeCountry = true
settings.UploadResults = true
settings.SendCrashReports = true
@@ -99,13 +97,6 @@ func Onboarding(config *config.Config) error {
Default: true,
},
},
{
Name: "IncludeCountry",
Prompt: &survey.Confirm{
Message: "Can we include your country name?",
Default: true,
},
},
{
Name: "UploadResults",
Prompt: &survey.Confirm{
@@ -131,7 +122,6 @@ func Onboarding(config *config.Config) error {
config.Lock()
config.InformedConsent = true
config.Sharing.IncludeCountry = settings.IncludeCountry
config.Advanced.SendCrashReports = settings.SendCrashReports
config.Sharing.IncludeIP = settings.IncludeIP
config.Sharing.IncludeASN = settings.IncludeNetwork
+2 -1
View File
@@ -116,7 +116,8 @@ func init() {
// Make sure we share what the user wants us to share.
ctx.Session.SetIncludeProbeIP(ctx.Config.Sharing.IncludeIP)
ctx.Session.SetIncludeProbeASN(ctx.Config.Sharing.IncludeASN)
ctx.Session.SetIncludeProbeCC(ctx.Config.Sharing.IncludeCountry)
// Always include probe_cc
ctx.Session.SetIncludeProbeCC(true)
return nil
})