chore: merge probe-engine into probe-cli (#201)
This is how I did it: 1. `git clone https://github.com/ooni/probe-engine internal/engine` 2. ``` (cd internal/engine && git describe --tags) v0.23.0 ``` 3. `nvim go.mod` (merging `go.mod` with `internal/engine/go.mod` 4. `rm -rf internal/.git internal/engine/go.{mod,sum}` 5. `git add internal/engine` 6. `find . -type f -name \*.go -exec sed -i 's@/ooni/probe-engine@/ooni/probe-cli/v3/internal/engine@g' {} \;` 7. `go build ./...` (passes) 8. `go test -race ./...` (temporary failure on RiseupVPN) 9. `go mod tidy` 10. this commit message Once this piece of work is done, we can build a new version of `ooniprobe` that is using `internal/engine` directly. We need to do more work to ensure all the other functionality in `probe-engine` (e.g. making mobile packages) are still WAI. Part of https://github.com/ooni/probe/issues/1335
This commit is contained in:
@@ -0,0 +1,73 @@
|
||||
package probeservices_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/ooni/probe-cli/v3/internal/engine/probeservices"
|
||||
"github.com/ooni/probe-cli/v3/internal/engine/probeservices/testorchestra"
|
||||
)
|
||||
|
||||
func TestMaybeLogin(t *testing.T) {
|
||||
t.Run("when we already have a token", func(t *testing.T) {
|
||||
clnt := newclient()
|
||||
state := probeservices.State{
|
||||
Expire: time.Now().Add(time.Hour),
|
||||
Token: "xx-xxx-x-xxxx",
|
||||
}
|
||||
if err := clnt.StateFile.Set(state); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
ctx := context.Background()
|
||||
if err := clnt.MaybeLogin(ctx); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
})
|
||||
t.Run("when we have already registered", func(t *testing.T) {
|
||||
clnt := newclient()
|
||||
state := probeservices.State{
|
||||
// Explicitly empty to clarify what this test does
|
||||
}
|
||||
if err := clnt.StateFile.Set(state); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
ctx := context.Background()
|
||||
if err := clnt.MaybeLogin(ctx); err == nil {
|
||||
t.Fatal("expected an error here")
|
||||
}
|
||||
})
|
||||
t.Run("when the API call fails", func(t *testing.T) {
|
||||
clnt := newclient()
|
||||
clnt.BaseURL = "\t\t\t" // causes the code to fail
|
||||
state := probeservices.State{
|
||||
ClientID: "xx-xxx-x-xxxx",
|
||||
Password: "xx",
|
||||
}
|
||||
if err := clnt.StateFile.Set(state); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
ctx := context.Background()
|
||||
if err := clnt.MaybeLogin(ctx); err == nil {
|
||||
t.Fatal("expected an error here")
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestMaybeLoginIdempotent(t *testing.T) {
|
||||
clnt := newclient()
|
||||
ctx := context.Background()
|
||||
metadata := testorchestra.MetadataFixture()
|
||||
if err := clnt.MaybeRegister(ctx, metadata); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := clnt.MaybeLogin(ctx); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := clnt.MaybeLogin(ctx); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if clnt.LoginCalls.Load() != 1 {
|
||||
t.Fatal("called login API too many times")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user