From d4d1ac38328607e51b9c2b339b047c130cfd9f2e Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Fri, 4 Jun 2021 17:44:13 +0200 Subject: [PATCH] cleanup(ndt7): remove redundant/unused code (#360) --- internal/engine/experiment/ndt7/ndt7.go | 4 ++-- internal/engine/experiment/ndt7/ndt7_test.go | 11 ----------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/internal/engine/experiment/ndt7/ndt7.go b/internal/engine/experiment/ndt7/ndt7.go index 0c39336..d5b7f12 100644 --- a/internal/engine/experiment/ndt7/ndt7.go +++ b/internal/engine/experiment/ndt7/ndt7.go @@ -109,7 +109,7 @@ func (m *Measurer) doDownload( callbacks model.ExperimentCallbacks, tk *TestKeys, URL string, ) error { - if m.config.noDownload == true { + if m.config.noDownload { return nil // useful to make tests faster } conn, err := newDialManager(URL, @@ -179,7 +179,7 @@ func (m *Measurer) doUpload( callbacks model.ExperimentCallbacks, tk *TestKeys, URL string, ) error { - if m.config.noUpload == true { + if m.config.noUpload { return nil // useful to make tests faster } conn, err := newDialManager(URL, diff --git a/internal/engine/experiment/ndt7/ndt7_test.go b/internal/engine/experiment/ndt7/ndt7_test.go index c209d14..1e38b69 100644 --- a/internal/engine/experiment/ndt7/ndt7_test.go +++ b/internal/engine/experiment/ndt7/ndt7_test.go @@ -40,17 +40,6 @@ func TestDiscoverCancelledContext(t *testing.T) { } } -type verifyRequestTransport struct { - ExpectedError error -} - -func (txp *verifyRequestTransport) RoundTrip(req *http.Request) (*http.Response, error) { - if req.URL.RawQuery != "ip=1.2.3.4" { - return nil, errors.New("invalid req.URL.RawQuery") - } - return nil, txp.ExpectedError -} - func TestDoDownloadWithCancelledContext(t *testing.T) { m := new(Measurer) sess := &mockable.Session{