feat(oonirun): improve tests (#915)

See https://github.com/ooni/probe/issues/2184 While there, rename `runtimex.PanicIfFalse` to `runtimex.Assert` (it was about time...)
2022-08-31 18:40:27 +02:00
parent a8a29cc0dd
commit d0da224a2a
32 changed files with 1837 additions and 112 deletions
@@ -33,7 +33,7 @@ func NewFailureStr(err error) FailureStr {
 	if !errors.As(err, &errWrapper) {
 		err := netxlite.NewTopLevelGenericErrWrapper(err)
 		couldConvert := errors.As(err, &errWrapper)
-		runtimex.PanicIfFalse(couldConvert, "we should have an ErrWrapper here")
+		runtimex.Assert(couldConvert, "we should have an ErrWrapper here")
 	}
 	s := errWrapper.Failure
 	if s == "" {