cleanup: remove ConnID, DialID, TransactionID (#395)

We are not using them anymore. The only nettest still using the
legacy netx implementation is tor, for which setting these fields
is useless, because it performs each measurement into a separate
goroutine. Hence, let us start removing this part of the legacy
netx codebase, which is hampering progress in other areas.

Occurred to me while doing testing for the recent changes in
error mapping (https://github.com/ooni/probe/issues/1505).
This commit is contained in:
Simone Basso
2021-06-23 13:36:45 +02:00
committed by GitHub
parent 1fefe5d9b8
commit c74c94d616
32 changed files with 78 additions and 896 deletions
@@ -112,9 +112,6 @@ func TestSuccess(t *testing.T) {
if request.T != 0 {
t.Fatal("invalid Requests[0].T")
}
if request.TransactionID != 0 {
t.Fatal("invalid Requests[0].TransactionID")
}
if tk.SOCKSProxy != nil {
t.Fatal("invalid SOCKSProxy")
}
@@ -223,9 +220,6 @@ func TestCancelledContext(t *testing.T) {
if request.T != 0 {
t.Fatal("invalid Requests[0].T")
}
if request.TransactionID != 0 {
t.Fatal("invalid Requests[0].TransactionID")
}
if tk.SOCKSProxy != nil {
t.Fatal("invalid SOCKSProxy")
}