c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #108 from ooni/issue/316

Browse Source 
nettests.go: don't stop when measurement is failed
This commit is contained in:
Arturo Filastò 2020-02-13 14:22:59 +01:00 committed by GitHub
commit ac893c9095
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nettests/nettests.go
View File

@ -125,7 +125,10 @@ func (c *Controller) Run(builder *engine.ExperimentBuilder, inputs []string) err
if err := c.msmts[idx64].Failed(c.Ctx.DB, err.Error()); err != nil { if err := c.msmts[idx64].Failed(c.Ctx.DB, err.Error()); err != nil {
return errors.Wrap(err, "failed to mark measurement as failed") return errors.Wrap(err, "failed to mark measurement as failed")
} }
continue // Even with a failed measurement, we want to continue. We want to
// record and submit the information we have. Saving the information
// is useful for local inspection. Submitting it is useful to us to
// undertsand what went wrong (censorship? bug? anomaly?).
} }
if c.Ctx.Config.Sharing.UploadResults { if c.Ctx.Config.Sharing.UploadResults {