chore: rename stun_reachability => stunreachability (#254)

See https://github.com/ooni/probe/issues/1394

Ok @hellais @FedericoCeratto

cmd/ooniprobe/internal/nettests/stunreachability.go

@@ -5,7 +5,7 @@ type STUNReachability struct{}
 
 // Run starts the nettest.
 func (n STUNReachability) Run(ctl *Controller) error {
-	builder, err := ctl.Session.NewExperimentBuilder("stun_reachability")
+	builder, err := ctl.Session.NewExperimentBuilder("stunreachability")
 	if err != nil {
 		return err
 	}

internal/engine/allexperiments.go

@@ -241,7 +241,7 @@ var experimentsByName = map[string]func(*Session) *ExperimentBuilder{
 		}
 	},
 
-	"stun_reachability": func(session *Session) *ExperimentBuilder {
+	"stunreachability": func(session *Session) *ExperimentBuilder {
 		return &ExperimentBuilder{
 			build: func(config interface{}) *Experiment {
 				return NewExperiment(session, stunreachability.NewExperimentMeasurer(

internal/engine/experiment/stunreachability/stunreachability.go

@@ -19,8 +19,8 @@ import (
 )
 
 const (
-	testName    = "stun_reachability"
-	testVersion = "0.1.0"
+	testName    = "stunreachability"
+	testVersion = "0.2.0"
 )
 
 // Config contains the experiment config.

internal/engine/experiment/stunreachability/stunreachability_test.go

@@ -18,10 +18,10 @@ import (
 
 func TestMeasurerExperimentNameVersion(t *testing.T) {
 	measurer := stunreachability.NewExperimentMeasurer(stunreachability.Config{})
-	if measurer.ExperimentName() != "stun_reachability" {
+	if measurer.ExperimentName() != "stunreachability" {
 		t.Fatal("unexpected ExperimentName")
 	}
-	if measurer.ExperimentVersion() != "0.1.0" {
+	if measurer.ExperimentVersion() != "0.2.0" {
 		t.Fatal("unexpected ExperimentVersion")
 	}
 }