Fix a very annoying logic bug in URL insertion

Write test case for it
This commit is contained in:
Arturo Filastò
2018-09-12 18:47:57 +02:00
parent b1ae8bc13e
commit 7f5df07782
4 changed files with 63 additions and 35 deletions
+1 -1
View File
@@ -176,12 +176,12 @@ func (c *Controller) Init(nt *mk.Nettest) error {
nt.On("status.measurement_start", func(e mk.Event) {
log.Debugf(color.RedString(e.Key))
idx := e.Value.Idx
urlID := sql.NullInt64{Int64: 0, Valid: false}
if c.inputIdxMap != nil {
urlID = sql.NullInt64{Int64: c.inputIdxMap[idx], Valid: true}
}
log.Debugf("👁 %d %s %d", idx, e.Value.Input, urlID.Int64)
msmt, err := database.CreateMeasurement(c.Ctx.DB, reportID, testName, resultID, reportFilePath, urlID)
if err != nil {
log.WithError(err).Error("Failed to create measurement")
+1
View File
@@ -59,6 +59,7 @@ func lookupURLs(ctl *nettests.Controller) ([]string, map[int64]int64, error) {
if err != nil {
log.Error("failed to add to the URL table")
}
log.Debugf("Mapped URL %s to idx %d and urlID %d", url.URL, idx, urlID)
urlIDMap[int64(idx)] = urlID
urls = append(urls, url.URL)
}