cli: upgrade to lucas-clemente/quic-go@v0.27.0 (#715)

* quic-go upgrade: replaced Session/EarlySession with Connection/EarlyConnection

* quic-go upgrade: added context to RoundTripper.Dial

* quic-go upgrade: made corresponding changes to tutorial

* quic-go upgrade: changed sess variable instances to qconn

* quic-go upgrade: made corresponding changes to tutorial

* cleanup: remove unnecessary comments

Those comments made sense in terms of illustrating the changes
but they're going to be less useful once we merge.

* fix(go.mod): apparently we needed `go1.18.1 mod tidy`

VSCode just warned me about this. It seems fine to apply this
change as part of the pull request at hand.

* cleanup(netxlite): http3dialer can be removed

We used to use http3dialer to glue a QUIC dialer, which had a
context as its first argument, to the Dial function used by the
HTTP3 transport, which did not have a context as its first
argument.

Now that HTTP3 transport has a Dial function taking a context as
its first argument, we don't need http3dialer
anymore, since we can use the QUIC dialer directly.

Cc: @DecFox

* Revert "cleanup(netxlite): http3dialer can be removed"

This reverts commit c62244c620cee5fadcc2ca89d8228c8db0b96add
to investigate the build failure mentioned at
https://github.com/ooni/probe-cli/pull/715#issuecomment-1119450484

* chore(netx): show that test was already broken

We didn't see the breakage before because we were not using
the created transport, but the issue of using a nil dialer was
already present before, we just didn't see it.

Now we understand why removing the http3transport in
c62244c620cee5fadcc2ca89d8228c8db0b96add did cause the
breakage mentioned at
https://github.com/ooni/probe-cli/pull/715#issuecomment-1119450484

* fix(netx): convert broken integration test to working unit test

There's no point in using the network here. Add a fake dialer that
breaks and ensure we're getting the expected error.

We've now improved upon the original test because the original test was
not doing anything while now we're testing whether we get back a QUIC
dialer that _can be used_.

After this commit, I can then readd the cleanup commit
c62244c620cee5fadcc2ca89d8228c8db0b96add and it won't be
broken anymore (at least, this is what I expected to happen).

* Revert "Revert "cleanup(netxlite): http3dialer can be removed""

This reverts commit 0e254bfc6ba3bfd65365ce3d8de2c8ec51b925ff
because now we should have fixed the broken test.

Co-authored-by: decfox <decfox>
Co-authored-by: Simone Basso <bassosimone@gmail.com>

internal/engine/experiment/websteps/factory.go

@@ -59,12 +59,12 @@ func NewQUICDialerResolver(resolver model.Resolver) model.QUICDialer {
 }
 
 // NewSingleH3Transport creates an http3.RoundTripper.
-func NewSingleH3Transport(qsess quic.EarlySession, tlscfg *tls.Config, qcfg *quic.Config) http.RoundTripper {
+func NewSingleH3Transport(qconn quic.EarlyConnection, tlscfg *tls.Config, qcfg *quic.Config) http.RoundTripper {
 	transport := &http3.RoundTripper{
 		DisableCompression: true,
 		TLSClientConfig:    tlscfg,
 		QuicConfig:         qcfg,
-		Dial:               (&SingleDialerH3{qsess: &qsess}).Dial,
+		Dial:               (&SingleDialerH3{qconn: &qconn}).Dial,
 	}
 	return transport
 }
@@ -117,16 +117,16 @@ func (s *SingleDialer) DialContext(ctx context.Context, network string, addr str
 
 type SingleDialerH3 struct {
 	sync.Mutex
-	qsess *quic.EarlySession
+	qconn *quic.EarlyConnection
 }
 
-func (s *SingleDialerH3) Dial(network, addr string, tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlySession, error) {
+func (s *SingleDialerH3) Dial(ctx context.Context, network, addr string, tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlyConnection, error) {
 	s.Lock()
 	defer s.Unlock()
-	if s.qsess == nil {
+	if s.qconn == nil {
 		return nil, ErrNoConnReuse
 	}
-	qs := s.qsess
-	s.qsess = nil
+	qs := s.qconn
+	s.qconn = nil
 	return *qs, nil
 }

internal/engine/experiment/websteps/quic.go

@@ -17,7 +17,7 @@ type QUICConfig struct {
 }
 
 // QUICDo performs the QUIC check.
-func QUICDo(ctx context.Context, config QUICConfig) (quic.EarlySession, error) {
+func QUICDo(ctx context.Context, config QUICConfig) (quic.EarlyConnection, error) {
 	if config.QUICDialer != nil {
 		return config.QUICDialer.DialContext(ctx, "udp", config.Endpoint, config.TLSConf, &quic.Config{})
 	}

internal/engine/netx/httptransport/http3transport_test.go

@@ -1,12 +1,40 @@
 package httptransport_test
 
 import (
+	"context"
+	"crypto/tls"
+	"errors"
+	"net/http"
 	"testing"
 
+	"github.com/lucas-clemente/quic-go"
 	"github.com/ooni/probe-cli/v3/internal/engine/netx/httptransport"
+	"github.com/ooni/probe-cli/v3/internal/model/mocks"
 )
 
 func TestNewHTTP3Transport(t *testing.T) {
-	// mainly to cover a line which otherwise won't be directly covered
-	httptransport.NewHTTP3Transport(httptransport.Config{})
+	// make sure we can create a working transport using this factory.
+	expected := errors.New("mocked error")
+	txp := httptransport.NewHTTP3Transport(httptransport.Config{
+		QUICDialer: &mocks.QUICDialer{
+			MockDialContext: func(ctx context.Context, network, address string,
+				tlsConfig *tls.Config, quicConfig *quic.Config) (quic.EarlyConnection, error) {
+				return nil, expected
+			},
+			MockCloseIdleConnections: func() {
+				// nothing
+			},
+		},
+	})
+	req, err := http.NewRequest("GET", "https://google.com", nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	resp, err := txp.RoundTrip(req)
+	if !errors.Is(err, expected) {
+		t.Fatal("unexpected err", err)
+	}
+	if resp != nil {
+		t.Fatal("expected nil resp")
+	}
 }

internal/engine/netx/quicdialer/connectionstate.go

@@ -7,6 +7,6 @@ import (
 )
 
 // connectionState returns the ConnectionState of a QUIC Session.
-func connectionState(sess quic.EarlySession) tls.ConnectionState {
+func connectionState(sess quic.EarlyConnection) tls.ConnectionState {
 	return sess.ConnectionState().TLS.ConnectionState
 }

internal/engine/netx/quicdialer/saver.go

@@ -19,7 +19,7 @@ type HandshakeSaver struct {
 
 // DialContext implements ContextDialer.DialContext
 func (h HandshakeSaver) DialContext(ctx context.Context, network string,
-	host string, tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlySession, error) {
+	host string, tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlyConnection, error) {
 	start := time.Now()
 	// TODO(bassosimone): in the future we probably want to also save
 	// information about what versions we're willing to accept.

internal/engine/netx/quicdialer/saver_test.go

@@ -18,12 +18,12 @@ import (
 
 type MockDialer struct {
 	Dialer model.QUICDialer
-	Sess   quic.EarlySession
+	Sess   quic.EarlyConnection
 	Err    error
 }
 
 func (d MockDialer) DialContext(ctx context.Context, network, host string,
-	tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlySession, error) {
+	tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlyConnection, error) {
 	if d.Dialer != nil {
 		return d.Dialer.DialContext(ctx, network, host, tlsCfg, cfg)
 	}