c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup(ooniprobe): remove unused send_crash_report option (#578)

Browse Source 
Closes https://github.com/ooni/probe/issues/1766
This commit is contained in:
Simone Basso 2021-11-05 13:26:08 +01:00 committed by GitHub
parent 8dd051ead0
commit 5b8f4546f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/ooniprobe/internal/cli/onboard/onboard.go
View File

@ -122,7 +122,6 @@ func Onboarding(config *config.Config) error {
config.Lock() config.Lock()
config.InformedConsent = true config.InformedConsent = true
config.Advanced.SendCrashReports = settings.SendCrashReports
config.Sharing.UploadResults = settings.UploadResults config.Sharing.UploadResults = settings.UploadResults
config.Unlock() config.Unlock()

4
cmd/ooniprobe/internal/config/settings.go
View File

@ -6,9 +6,7 @@ type Sharing struct {
} }
// Advanced settings // Advanced settings
type Advanced struct { type Advanced struct{}
SendCrashReports bool `json:"send_crash_reports"`
}
// Nettests related settings // Nettests related settings
type Nettests struct { type Nettests struct {

1
cmd/ooniprobe/internal/config/testdata/valid-config.json vendored
View File

@ -8,6 +8,5 @@
"websites_max_runtime": 0 "websites_max_runtime": 0
}, },
"advanced": { "advanced": {
"send_crash_reports": true
} }
} }

4
cmd/ooniprobe/internal/ooni/default-config.json
View File

@ -7,7 +7,5 @@
"nettests": { "nettests": {
"websites_max_runtime": 0 "websites_max_runtime": 0
}, },
"advanced": { "advanced": {}
"send_crash_reports": true
}
} }

4
cmd/ooniprobe/testdata/testing-config.json vendored
View File

@ -7,7 +7,5 @@
"nettests": { "nettests": {
"websites_max_runtime": 15 "websites_max_runtime": 15
}, },
"advanced": { "advanced": {}
"send_crash_reports": true
}
} }

4
debian/ooniprobe.conf.disabled vendored
View File

@ -9,7 +9,5 @@
"websites_max_runtime": 0, "websites_max_runtime": 0,
"websites_enabled_category_codes": null "websites_enabled_category_codes": null
}, },
"advanced": { "advanced": {}
"send_crash_reports": true
}
} }