cleanup(ooniprobe): remove unused send_crash_report option (#578)

Closes https://github.com/ooni/probe/issues/1766

cmd/ooniprobe/internal/cli/onboard/onboard.go

@@ -122,7 +122,6 @@ func Onboarding(config *config.Config) error {
 
 	config.Lock()
 	config.InformedConsent = true
-	config.Advanced.SendCrashReports = settings.SendCrashReports
 	config.Sharing.UploadResults = settings.UploadResults
 	config.Unlock()
 

cmd/ooniprobe/internal/config/settings.go

@@ -6,9 +6,7 @@ type Sharing struct {
 }
 
 // Advanced settings
-type Advanced struct {
-	SendCrashReports bool `json:"send_crash_reports"`
-}
+type Advanced struct{}
 
 // Nettests related settings
 type Nettests struct {

cmd/ooniprobe/internal/config/testdata/valid-config.json

@@ -8,6 +8,5 @@
     "websites_max_runtime": 0
   },
   "advanced": {
-    "send_crash_reports": true
   }
 }

cmd/ooniprobe/internal/ooni/default-config.json

@@ -7,7 +7,5 @@
   "nettests": {
     "websites_max_runtime": 0
   },
-  "advanced": {
-    "send_crash_reports": true
-  }
+  "advanced": {}
 }

cmd/ooniprobe/testdata/testing-config.json

@@ -7,7 +7,5 @@
   "nettests": {
     "websites_max_runtime": 15
   },
-  "advanced": {
-    "send_crash_reports": true
-  }
+  "advanced": {}
 }