c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: apply staticcheck suggestions (#262)

Browse Source 
Preliminary work done as part of https://github.com/ooni/probe/issues/1299
This commit is contained in:
Simone Basso 2021-03-24 12:35:53 +01:00 committed by GitHub
parent 9c820cf855
commit 576059b3fa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/engine/experimentbuilder.go
View File

@ -193,7 +193,7 @@ func canonicalizeExperimentName(name string) string {
} }
func newExperimentBuilder(session *Session, name string) (*ExperimentBuilder, error) { func newExperimentBuilder(session *Session, name string) (*ExperimentBuilder, error) {
factory, _ := experimentsByName[canonicalizeExperimentName(name)] factory := experimentsByName[canonicalizeExperimentName(name)]
if factory == nil { if factory == nil {
return nil, fmt.Errorf("no such experiment: %s", name) return nil, fmt.Errorf("no such experiment: %s", name)
} }

2
internal/engine/probeservices/benchselect.go
View File

@ -85,7 +85,7 @@ func (c *Candidate) try(ctx context.Context, sess Session) {
} }
start := time.Now() start := time.Now()
testhelpers, err := client.GetTestHelpers(ctx) testhelpers, err := client.GetTestHelpers(ctx)
c.Duration = time.Now().Sub(start) c.Duration = time.Since(start)
c.Err = err c.Err = err
c.TestHelpers = testhelpers c.TestHelpers = testhelpers
sess.Logger().Debugf("probe services: %+v: %+v %s", c.Endpoint, err, c.Duration) sess.Logger().Debugf("probe services: %+v: %+v %s", c.Endpoint, err, c.Duration)