cleanup: remove unnecessary legacy interfaces (#656)

This diff addresses another point of https://github.com/ooni/probe/issues/1956:

> - [ ] observe that we're still using a bunch of private interfaces for common interfaces such as the `Dialer`, so we can get rid of these private interfaces and always use the ones in `model`, which allows us to remove a bunch of legacy wrappers

Additional cleanups may still be possible. The more I cleanup, the more I see
there's extra legacy code we can dispose of (which seems good?).

internal/engine/netx/tlsdialer/saver.go

@@ -7,12 +7,13 @@ import (
 	"time"
 
 	"github.com/ooni/probe-cli/v3/internal/engine/netx/trace"
+	"github.com/ooni/probe-cli/v3/internal/model"
 	"github.com/ooni/probe-cli/v3/internal/netxlite"
 )
 
 // SaverTLSHandshaker saves events occurring during the handshake
 type SaverTLSHandshaker struct {
-	TLSHandshaker
+	model.TLSHandshaker
 	Saver *trace.Saver
 }
 
@@ -46,4 +47,4 @@ func (h SaverTLSHandshaker) Handshake(
 	return tlsconn, state, err
 }
 
-var _ TLSHandshaker = SaverTLSHandshaker{}
+var _ model.TLSHandshaker = SaverTLSHandshaker{}

internal/engine/netx/tlsdialer/saver_test.go

@@ -3,7 +3,6 @@ package tlsdialer_test
 import (
 	"context"
 	"crypto/tls"
-	"net"
 	"reflect"
 	"testing"
 	"time"
@@ -23,9 +22,7 @@ func TestSaverTLSHandshakerSuccessWithReadWrite(t *testing.T) {
 	saver := &trace.Saver{}
 	tlsdlr := &netxlite.TLSDialerLegacy{
 		Config: &tls.Config{NextProtos: nextprotos},
-		Dialer: netxlite.NewDialerLegacyAdapter(
-			dialer.New(&dialer.Config{ReadWriteSaver: saver}, &net.Resolver{}),
-		),
+		Dialer: dialer.New(&dialer.Config{ReadWriteSaver: saver}, netxlite.DefaultResolver),
 		TLSHandshaker: tlsdialer.SaverTLSHandshaker{
 			TLSHandshaker: &netxlite.TLSHandshakerConfigurable{},
 			Saver:         saver,

internal/engine/netx/tlsdialer/tls.go

@@ -1,19 +0,0 @@
-// Package tlsdialer contains code to establish TLS connections.
-package tlsdialer
-
-import (
-	"context"
-	"crypto/tls"
-	"net"
-)
-
-// UnderlyingDialer is the underlying dialer type.
-type UnderlyingDialer interface {
-	DialContext(ctx context.Context, network, address string) (net.Conn, error)
-}
-
-// TLSHandshaker is the generic TLS handshaker
-type TLSHandshaker interface {
-	Handshake(ctx context.Context, conn net.Conn, config *tls.Config) (
-		net.Conn, tls.ConnectionState, error)
-}