cleanup: remove unnecessary legacy interfaces (#656)

This diff addresses another point of https://github.com/ooni/probe/issues/1956:

> - [ ] observe that we're still using a bunch of private interfaces for common interfaces such as the `Dialer`, so we can get rid of these private interfaces and always use the ones in `model`, which allows us to remove a bunch of legacy wrappers

Additional cleanups may still be possible. The more I cleanup, the more I see
there's extra legacy code we can dispose of (which seems good?).
This commit is contained in:
Simone Basso
2022-01-07 18:33:37 +01:00
committed by GitHub
parent 1c057d322d
commit 566c6b246a
76 changed files with 328 additions and 736 deletions
+1 -8
View File
@@ -89,19 +89,12 @@ type resolverIPLookupper interface {
LookupResolverIP(ctx context.Context) (addr string, err error)
}
// Resolver is a DNS resolver.
type Resolver interface {
LookupHost(ctx context.Context, domain string) ([]string, error)
Network() string
Address() string
}
// Config contains configuration for a geolocate Task.
type Config struct {
// Resolver is the resolver we should use when
// making requests for discovering the IP. When
// this field is not set, we use the stdlib.
Resolver Resolver
Resolver model.Resolver
// Logger is the logger to use. If not set, then we will
// use a logger that discards all messages.
+1 -1
View File
@@ -65,7 +65,7 @@ var (
type ipLookupClient struct {
// Resolver is the resolver to use for HTTP.
Resolver Resolver
Resolver model.Resolver
// Logger is the logger to use
Logger model.Logger