c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Edits to the measurex tutorial (#534)

Browse Source
This commit is contained in:
Arturo Filastò
2021-10-11 17:48:45 +02:00
committed by GitHub
parent 1ffb2db0ca
commit 46e00888ae
14 changed files with 58 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/tutorial/measurex/chapter05/README.md
+6 -6
View File
@@ -10,7 +10,7 @@ For this reason, we will not see a connect event, but we
will only see a "QUIC handshake event".
Having said that, let us now move on and see the code of
the simple program that shows this functionality.
the simple program that uses this functionality.
(This file is auto-generated. Do not edit it directly! To apply
changes you need to modify `./internal/tutorial/measure/chapter05/main.go`.)
@@ -63,7 +63,7 @@ The same remarks mentioned in the previous chapter regarding
the arguments for the TLS config also apply here. We need
to specify the SNI (`ServerName`), the ALPN (`NextProtos`),
and the CA pool we want to use. Here, again, we're using
the CA pool from cURL that we bundle with ooniprobe.
the CA pool from cURL that we bundle with OONI Probe.
As we did in the previous chapters, here's the usual three
lines of code for printing the resulting measurement.
@@ -224,7 +224,7 @@ Produces this JSON:
],
// This section describes the QUIC handshake and it has
// basically the same fields of the TLS handshake.
// basically the same fields as the TLS handshake.
"quic_handshake": [
{
"cipher_suite": "TLS_CHACHA20_POLY1305_SHA256",
@@ -260,9 +260,9 @@ Produces this JSON:
}
```
Here are some suggestions on other experiments to run:
Here are some suggestions for other experiments to run:
1. obtain a timeout by connecting on a port that is not
1. obtain a timeout by connecting to a port that is not
actually listening for QUIC;
2. obtain a certificate validation error by forcing
@@ -271,7 +271,7 @@ a different SNI;
3. use a different ALPN (by changing the code), and see
how the error and the oddity are handled. Can we do
anything about this by changing `./internal/netxlite/errorx`
to better support for this specific error condition?
to better support this specific error condition?
## Conclusion
internal/tutorial/measurex/chapter05/main.go
+6 -6
View File
@@ -11,7 +11,7 @@
// will only see a "QUIC handshake event".
//
// Having said that, let us now move on and see the code of
// the simple program that shows this functionality.
// the simple program that uses this functionality.
//
// (This file is auto-generated. Do not edit it directly! To apply
// changes you need to modify `./internal/tutorial/measure/chapter05/main.go`.)
@@ -64,7 +64,7 @@ func main() {
// the arguments for the TLS config also apply here. We need
// to specify the SNI (`ServerName`), the ALPN (`NextProtos`),
// and the CA pool we want to use. Here, again, we're using
// the CA pool from cURL that we bundle with ooniprobe.
// the CA pool from cURL that we bundle with OONI Probe.
//
// As we did in the previous chapters, here's the usual three
// lines of code for printing the resulting measurement.
@@ -225,7 +225,7 @@ func main() {
// ],
//
// // This section describes the QUIC handshake and it has
// // basically the same fields of the TLS handshake.
// // basically the same fields as the TLS handshake.
// "quic_handshake": [
// {
// "cipher_suite": "TLS_CHACHA20_POLY1305_SHA256",
@@ -261,9 +261,9 @@ func main() {
// }
// ```
//
// Here are some suggestions on other experiments to run:
// Here are some suggestions for other experiments to run:
//
// 1. obtain a timeout by connecting on a port that is not
// 1. obtain a timeout by connecting to a port that is not
// actually listening for QUIC;
//
// 2. obtain a certificate validation error by forcing
@@ -272,7 +272,7 @@ func main() {
// 3. use a different ALPN (by changing the code), and see
// how the error and the oddity are handled. Can we do
// anything about this by changing `./internal/netxlite/errorx`
// to better support for this specific error condition?
// to better support this specific error condition?
//
// ## Conclusion
//