refactor(session.go): replace engine/netx with netxlite (#767)
This diff replaces engine/netx code with netxlite code in the engine/session.go file. To this end, we needed to move some code from engine/netx to netxlite. While there, we did review and improve the unit tests. A notable change in this diff is (or seems to be) that in engine/session.go we're not filtering for bogons anymore so that, in principle, we could believe a resolver returning to us bogon IP addresses for OONI services. However, I did not bother with changing bogons filtering because the sessionresolver package is already filtering for bogons, so it is actually okay to avoid doing that again the session.go code. See: https://github.com/ooni/probe-cli/blob/v3.15.0-alpha.1/internal/engine/internal/sessionresolver/resolvermaker.go#L88 There are two reference issues for this cleanup: 1. https://github.com/ooni/probe/issues/2115 2. https://github.com/ooni/probe/issues/2121
This commit is contained in:
Simone Basso
GitHub
@@ -1,74 +1,5 @@
|
||||
package httptransport
|
||||
|
||||
import (
|
||||
"io"
|
||||
"net/http"
|
||||
import "github.com/ooni/probe-cli/v3/internal/bytecounter"
|
||||
|
||||
"github.com/ooni/probe-cli/v3/internal/bytecounter"
|
||||
"github.com/ooni/probe-cli/v3/internal/model"
|
||||
)
|
||||
|
||||
// ByteCountingTransport is a RoundTripper that counts bytes.
|
||||
type ByteCountingTransport struct {
|
||||
model.HTTPTransport
|
||||
Counter *bytecounter.Counter
|
||||
}
|
||||
|
||||
// RoundTrip implements RoundTripper.RoundTrip
|
||||
func (txp ByteCountingTransport) RoundTrip(req *http.Request) (*http.Response, error) {
|
||||
if req.Body != nil {
|
||||
req.Body = byteCountingBody{
|
||||
ReadCloser: req.Body, Account: txp.Counter.CountBytesSent}
|
||||
}
|
||||
txp.estimateRequestMetadata(req)
|
||||
resp, err := txp.HTTPTransport.RoundTrip(req)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
txp.estimateResponseMetadata(resp)
|
||||
resp.Body = byteCountingBody{
|
||||
ReadCloser: resp.Body, Account: txp.Counter.CountBytesReceived}
|
||||
return resp, nil
|
||||
}
|
||||
|
||||
func (txp ByteCountingTransport) estimateRequestMetadata(req *http.Request) {
|
||||
txp.Counter.CountBytesSent(len(req.Method))
|
||||
txp.Counter.CountBytesSent(len(req.URL.String()))
|
||||
for key, values := range req.Header {
|
||||
for _, value := range values {
|
||||
txp.Counter.CountBytesSent(len(key))
|
||||
txp.Counter.CountBytesSent(len(": "))
|
||||
txp.Counter.CountBytesSent(len(value))
|
||||
txp.Counter.CountBytesSent(len("\r\n"))
|
||||
}
|
||||
}
|
||||
txp.Counter.CountBytesSent(len("\r\n"))
|
||||
}
|
||||
|
||||
func (txp ByteCountingTransport) estimateResponseMetadata(resp *http.Response) {
|
||||
txp.Counter.CountBytesReceived(len(resp.Status))
|
||||
for key, values := range resp.Header {
|
||||
for _, value := range values {
|
||||
txp.Counter.CountBytesReceived(len(key))
|
||||
txp.Counter.CountBytesReceived(len(": "))
|
||||
txp.Counter.CountBytesReceived(len(value))
|
||||
txp.Counter.CountBytesReceived(len("\r\n"))
|
||||
}
|
||||
}
|
||||
txp.Counter.CountBytesReceived(len("\r\n"))
|
||||
}
|
||||
|
||||
type byteCountingBody struct {
|
||||
io.ReadCloser
|
||||
Account func(int)
|
||||
}
|
||||
|
||||
func (r byteCountingBody) Read(p []byte) (int, error) {
|
||||
count, err := r.ReadCloser.Read(p)
|
||||
if count > 0 {
|
||||
r.Account(count)
|
||||
}
|
||||
return count, err
|
||||
}
|
||||
|
||||
var _ model.HTTPTransport = ByteCountingTransport{}
|
||||
type ByteCountingTransport = bytecounter.HTTPTransport
|
||||
|
||||
@@ -1,129 +0,0 @@
|
||||
package httptransport_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"io"
|
||||
"net/http"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/ooni/probe-cli/v3/internal/bytecounter"
|
||||
"github.com/ooni/probe-cli/v3/internal/engine/netx/httptransport"
|
||||
"github.com/ooni/probe-cli/v3/internal/netxlite"
|
||||
)
|
||||
|
||||
func TestByteCounterFailure(t *testing.T) {
|
||||
counter := bytecounter.New()
|
||||
txp := httptransport.ByteCountingTransport{
|
||||
Counter: counter,
|
||||
HTTPTransport: httptransport.FakeTransport{
|
||||
Err: io.EOF,
|
||||
},
|
||||
}
|
||||
client := &http.Client{Transport: txp}
|
||||
req, err := http.NewRequest(
|
||||
"POST", "https://www.google.com", strings.NewReader("AAAAAA"))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
req.Header.Set("User-Agent", "antani-browser/1.0.0")
|
||||
resp, err := client.Do(req)
|
||||
if !errors.Is(err, io.EOF) {
|
||||
t.Fatal("not the error we expected")
|
||||
}
|
||||
if resp != nil {
|
||||
t.Fatal("expected nil response here")
|
||||
}
|
||||
if counter.Sent.Load() != 68 {
|
||||
t.Fatal("expected around 68 bytes sent")
|
||||
}
|
||||
if counter.Received.Load() != 0 {
|
||||
t.Fatal("expected zero bytes received")
|
||||
}
|
||||
}
|
||||
|
||||
func TestByteCounterSuccess(t *testing.T) {
|
||||
counter := bytecounter.New()
|
||||
txp := httptransport.ByteCountingTransport{
|
||||
Counter: counter,
|
||||
HTTPTransport: httptransport.FakeTransport{
|
||||
Resp: &http.Response{
|
||||
Body: io.NopCloser(strings.NewReader("1234567")),
|
||||
Header: http.Header{
|
||||
"Server": []string{"antani/0.1.0"},
|
||||
},
|
||||
Status: "200 OK",
|
||||
StatusCode: http.StatusOK,
|
||||
},
|
||||
},
|
||||
}
|
||||
client := &http.Client{Transport: txp}
|
||||
req, err := http.NewRequest(
|
||||
"POST", "https://www.google.com", strings.NewReader("AAAAAA"))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
req.Header.Set("User-Agent", "antani-browser/1.0.0")
|
||||
resp, err := client.Do(req)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
data, err := netxlite.ReadAllContext(context.Background(), resp.Body)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
resp.Body.Close()
|
||||
if string(data) != "1234567" {
|
||||
t.Fatal("expected a different body here")
|
||||
}
|
||||
if counter.Sent.Load() != 68 {
|
||||
t.Fatal("expected around 68 bytes sent")
|
||||
}
|
||||
if counter.Received.Load() != 37 {
|
||||
t.Fatal("expected zero around 37 bytes received")
|
||||
}
|
||||
}
|
||||
|
||||
func TestByteCounterSuccessWithEOF(t *testing.T) {
|
||||
counter := bytecounter.New()
|
||||
txp := httptransport.ByteCountingTransport{
|
||||
Counter: counter,
|
||||
HTTPTransport: httptransport.FakeTransport{
|
||||
Resp: &http.Response{
|
||||
Body: bodyReaderWithEOF{},
|
||||
Header: http.Header{
|
||||
"Server": []string{"antani/0.1.0"},
|
||||
},
|
||||
Status: "200 OK",
|
||||
StatusCode: http.StatusOK,
|
||||
},
|
||||
},
|
||||
}
|
||||
client := &http.Client{Transport: txp}
|
||||
resp, err := client.Get("https://www.google.com")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
data, err := netxlite.ReadAllContext(context.Background(), resp.Body)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
resp.Body.Close()
|
||||
if string(data) != "A" {
|
||||
t.Fatal("expected a different body here")
|
||||
}
|
||||
}
|
||||
|
||||
type bodyReaderWithEOF struct{}
|
||||
|
||||
func (bodyReaderWithEOF) Read(p []byte) (int, error) {
|
||||
if len(p) < 1 {
|
||||
panic("should not happen")
|
||||
}
|
||||
p[0] = 'A'
|
||||
return 1, io.EOF // we want code to be robust to this
|
||||
}
|
||||
func (bodyReaderWithEOF) Close() error {
|
||||
return nil
|
||||
}
|
||||
Reference in New Issue
Block a user