fix(wcth): match legacy TH w/ empty DNS reply (#546)

See https://github.com/ooni/probe/issues/1707#issuecomment-944322725
This commit is contained in:
Simone Basso
2021-10-15 16:20:07 +02:00
committed by GitHub
parent 2d1666b88b
commit 2fa87f0e00
3 changed files with 11 additions and 3 deletions
+3
View File
@@ -64,6 +64,9 @@ func (r *SerialResolver) LookupHost(ctx context.Context, hostname string) ([]str
addrsA, errA := r.lookupHostWithRetry(ctx, hostname, dns.TypeA)
addrsAAAA, errAAAA := r.lookupHostWithRetry(ctx, hostname, dns.TypeAAAA)
if errA != nil && errAAAA != nil {
// Note: we choose to return the errA because we assume that
// it's the more meaningful one: the errAAAA may just be telling
// us that there is no AAAA record for the website.
return nil, errA
}
addrs = append(addrs, addrsA...)