Release 3.6.0 (#239)

* chore: update dependencies

* chore: update user agent for measurements

* chore: we're now at v3.6.0

* chore: update assets

* chore: update bundled CA

* fix: address some goreportcard.com warnings

* fix(debian/changelog): zap release that breaks out build scripts

We're forcing the content of changelog with `dch`, so it's fine to
not have any specific new release in there.

* fix: make sure tests are passing locally

Notably, I removed a chunk of code where we were checking for network
activity. Now we don't fetch the databases and it's not important. Before,
it was important because the databases are ~large.

* fix: temporarily comment out riseupvn integration tests

See https://github.com/ooni/probe/issues/1354 for work aimed at
reducing the rate of false positives (thanks @cyBerta!)

internal/engine/netx/dialer/errorwrapper.go

@@ -19,7 +19,7 @@ func (d ErrorWrapperDialer) DialContext(ctx context.Context, network, address st
 	conn, err := d.Dialer.DialContext(ctx, network, address)
 	err = errorx.SafeErrWrapperBuilder{
 		// ConnID does not make any sense if we've failed and the error
-		// does not make any sense (and is nil) if we succeded.
+		// does not make any sense (and is nil) if we succeeded.
 		DialID:    dialID,
 		Error:     err,
 		Operation: errorx.ConnectOperation,

internal/engine/netx/dialer/proxy.go

@@ -38,7 +38,7 @@ func WithProxyURL(ctx context.Context, url *url.URL) context.Context {
 
 // DialContext implements Dialer.DialContext
 func (d ProxyDialer) DialContext(ctx context.Context, network, address string) (net.Conn, error) {
-	url := ContextProxyURL(ctx) // context URL takes precendence
+	url := ContextProxyURL(ctx) // context URL takes precedence
 	if url == nil {
 		url = d.ProxyURL
 	}

internal/engine/netx/gocertifi/certifi.go

@@ -1,5 +1,5 @@
 // Code generated by go generate; DO NOT EDIT.
-// 2021-01-29 09:54:51.941105652 +0100 CET m=+1.231498959
+// 2021-03-03 11:48:43.129132377 +0100 CET m=+2.301468593
 // https://curl.haxx.se/ca/cacert.pem
 
 package gocertifi
@@ -3241,7 +3241,7 @@ kpzNNIaRkPpkUZ3+/uul9XXeifdy
 `
 
 // CACerts builds an X.509 certificate pool containing the
-// certificate bundle from https://curl.haxx.se/ca/cacert.pem fetch on 2021-01-29 09:54:51.941105652 +0100 CET m=+1.231498959.
+// certificate bundle from https://curl.haxx.se/ca/cacert.pem fetch on 2021-03-03 11:48:43.129132377 +0100 CET m=+2.301468593.
 // Returns nil on error along with an appropriate error code.
 func CACerts() (*x509.CertPool, error) {
 	pool := x509.NewCertPool()

internal/engine/netx/quicdialer/errorwrapper.go

@@ -22,7 +22,7 @@ func (d ErrorWrapperDialer) DialContext(
 	sess, err := d.Dialer.DialContext(ctx, network, host, tlsCfg, cfg)
 	err = errorx.SafeErrWrapperBuilder{
 		// ConnID does not make any sense if we've failed and the error
-		// does not make any sense (and is nil) if we succeded.
+		// does not make any sense (and is nil) if we succeeded.
 		DialID:    dialID,
 		Error:     err,
 		Operation: errorx.QUICHandshakeOperation,

internal/engine/netx/quicdialer/system_test.go

@@ -69,7 +69,7 @@ func TestSystemDialerSuccessWithReadWrite(t *testing.T) {
 			t.Fatal("unexpected Name")
 		}
 		if ev[idx].Time.Before(ev[idx-1].Time) {
-			t.Fatal("unexpected Time")
+			t.Fatal("unexpected Time", ev[idx].Time, ev[idx-1].Time)
 		}
 	}
 }

internal/engine/netx/resolver/encoder_test.go

@@ -51,7 +51,7 @@ func validate(t *testing.T, data []byte, qtype byte) {
 		t.Fatal("The name does not contain 1:x")
 	}
 	if data[14] != 3 || data[15] != byte('o') || data[16] != byte('r') || data[17] != byte('g') {
-		t.Fatal("The name does not containg 3:org")
+		t.Fatal("The name does not contain 3:org")
 	}
 	if data[18] != 0 {
 		t.Fatal("The name does not terminate where expected")

internal/engine/netx/resolver/integration_test.go

@@ -34,7 +34,7 @@ func testresolverquick(t *testing.T, reso resolver.Resolver) {
 		}
 	}
 	if !foundquad8 {
-		t.Fatalf("did not find 8.8.8.8 in ouput; output=%+v", addrs)
+		t.Fatalf("did not find 8.8.8.8 in output; output=%+v", addrs)
 	}
 }