Release 3.6.0 (#239)
* chore: update dependencies * chore: update user agent for measurements * chore: we're now at v3.6.0 * chore: update assets * chore: update bundled CA * fix: address some goreportcard.com warnings * fix(debian/changelog): zap release that breaks out build scripts We're forcing the content of changelog with `dch`, so it's fine to not have any specific new release in there. * fix: make sure tests are passing locally Notably, I removed a chunk of code where we were checking for network activity. Now we don't fetch the databases and it's not important. Before, it was important because the databases are ~large. * fix: temporarily comment out riseupvn integration tests See https://github.com/ooni/probe/issues/1354 for work aimed at reducing the rate of false positives (thanks @cyBerta!)
This commit is contained in:
@@ -109,7 +109,7 @@ func Summarize(tk *TestKeys) (out Summary) {
|
||||
tcpIP = "tcp_ip"
|
||||
)
|
||||
// If the measurement was for an HTTPS website and the HTTP experiment
|
||||
// succeded, then either there is a compromised CA in our pool (which is
|
||||
// succeeded, then either there is a compromised CA in our pool (which is
|
||||
// certifi-go), or there is transparent proxying, or we are actually
|
||||
// speaking with the legit server. We assume the latter. This applies
|
||||
// also to cases in which we are redirected to HTTPS.
|
||||
@@ -129,7 +129,7 @@ func Summarize(tk *TestKeys) (out Summary) {
|
||||
if tk.DNSExperimentFailure != nil &&
|
||||
*tk.DNSExperimentFailure == errorx.FailureDNSNXDOMAINError &&
|
||||
tk.DNSConsistency != nil && *tk.DNSConsistency == DNSConsistent {
|
||||
// TODO(bassosimone): MK flags this as accessible. This result is debateable. We
|
||||
// TODO(bassosimone): MK flags this as accessible. This result is debatable. We
|
||||
// are doing what MK does. But we most likely want to make it better later.
|
||||
//
|
||||
// See <https://github.com/ooni/probe-engine/issues/579>.
|
||||
@@ -146,7 +146,7 @@ func Summarize(tk *TestKeys) (out Summary) {
|
||||
out.Status |= StatusAnomalyDNS | StatusExperimentDNS
|
||||
return
|
||||
}
|
||||
// If we tried to connect more than once and never succeded and we were
|
||||
// If we tried to connect more than once and never succedeed and we were
|
||||
// able to measure DNS consistency, then we can conclude something.
|
||||
if tk.TCPConnectAttempts > 0 && tk.TCPConnectSuccesses <= 0 && tk.DNSConsistency != nil {
|
||||
out.Status |= StatusAnomalyConnect | StatusExperimentConnect
|
||||
|
||||
Reference in New Issue
Block a user