c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Release 3.6.0 (#239)

Browse Source 
* chore: update dependencies

* chore: update user agent for measurements

* chore: we're now at v3.6.0

* chore: update assets

* chore: update bundled CA

* fix: address some goreportcard.com warnings

* fix(debian/changelog): zap release that breaks out build scripts

We're forcing the content of changelog with `dch`, so it's fine to
not have any specific new release in there.

* fix: make sure tests are passing locally

Notably, I removed a chunk of code where we were checking for network
activity. Now we don't fetch the databases and it's not important. Before,
it was important because the databases are ~large.

* fix: temporarily comment out riseupvn integration tests

See https://github.com/ooni/probe/issues/1354 for work aimed at
reducing the rate of false positives (thanks @cyBerta!)
This commit is contained in:
Simone Basso
2021-03-03 14:42:17 +01:00
committed by GitHub
parent 034db78f94
commit 0d4323ae66
24 changed files with 80 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/engine/experiment/riseupvpn/riseupvpn_test.go
+2 -1
View File
@@ -278,6 +278,7 @@ func TestFailureGeoIpServiceBlocked(t *testing.T) {
}
func TestFailureGateway(t *testing.T) {
t.Skip("test currently not WAI - will restore after release")
var testCases = [...]string{"openvpn", "obfs4"}
eipService, err := fetchEipService()
if err != nil {
@@ -421,7 +422,7 @@ func runGatewayTest(t *testing.T, censoredGateway *SelfCensoredGateway) {
}
if tk.APIStatus == "blocked" {
t.Fatal("invalid ApiStatus")
t.Fatal("invalid ApiStatus", tk.APIStatus)
}
if tk.APIFailure != nil {
internal/engine/experiment/tor/tor_test.go
+1 -1
View File
@@ -100,7 +100,7 @@ func TestMeasurerMeasureFetchTorTargetsEmptyList(t *testing.T) {
func TestMeasurerMeasureGoodWithMockedOrchestra(t *testing.T) {
// This test mocks orchestra to return a nil list of targets, so the code runs
// but we don't perform any actualy network actions.
// but we don't perform any actual network actions.
measurer := NewMeasurer(Config{})
measurer.newOrchestraClient = func(ctx context.Context, sess model.ExperimentSession) (model.ExperimentOrchestraClient, error) {
return new(probeservices.Client), nil
internal/engine/experiment/webconnectivity/summary.go
+3 -3
View File
@@ -109,7 +109,7 @@ func Summarize(tk *TestKeys) (out Summary) {
tcpIP = "tcp_ip"
)
// If the measurement was for an HTTPS website and the HTTP experiment
// succeded, then either there is a compromised CA in our pool (which is
// succeeded, then either there is a compromised CA in our pool (which is
// certifi-go), or there is transparent proxying, or we are actually
// speaking with the legit server. We assume the latter. This applies
// also to cases in which we are redirected to HTTPS.
@@ -129,7 +129,7 @@ func Summarize(tk *TestKeys) (out Summary) {
if tk.DNSExperimentFailure != nil &&
*tk.DNSExperimentFailure == errorx.FailureDNSNXDOMAINError &&
tk.DNSConsistency != nil && *tk.DNSConsistency == DNSConsistent {
// TODO(bassosimone): MK flags this as accessible. This result is debateable. We
// TODO(bassosimone): MK flags this as accessible. This result is debatable. We
// are doing what MK does. But we most likely want to make it better later.
//
// See <https://github.com/ooni/probe-engine/issues/579>.
@@ -146,7 +146,7 @@ func Summarize(tk *TestKeys) (out Summary) {
out.Status |= StatusAnomalyDNS | StatusExperimentDNS
return
}
// If we tried to connect more than once and never succeded and we were
// If we tried to connect more than once and never succedeed and we were
// able to measure DNS consistency, then we can conclude something.
if tk.TCPConnectAttempts > 0 && tk.TCPConnectSuccesses <= 0 && tk.DNSConsistency != nil {
out.Status |= StatusAnomalyConnect | StatusExperimentConnect