e2dcd8ac66
Up to now, the xmpp-rs projects have been very strict about incoming
data. This has served us, as developers of the libraries, well,
uncovering bugs in our and remote implementations which we could then
get fixed.
However, this behaviour is unexpected to users of the library. In the
XMPP world, unexpected child elements and attributes are generally
expected to be ignored. While this could be opted-into previously, the
feature flag for that sounded more dangerous than it was
("disable-validation"). In addition, the tribal knowledge needed to know
about that feature flag may not have reached some people who tried the
library and gave up because of that.
With this change, we make the non-pedantic behaviour the default. For
development and debugging purposes, users can always opt into the
pedantic behaviour as needed, using the newly-introduced `pedantic`
feature flags on all affected crates.
78 lines
2.3 KiB
Rust
78 lines
2.3 KiB
Rust
// Copyright (c) 2018 Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
generate_elem_id!(
|
|
/// Represents a global, memorable, friendly or informal name chosen by a user.
|
|
Nick,
|
|
"nick",
|
|
NICK
|
|
);
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use minidom::Element;
|
|
#[cfg(feature = "pedantic")]
|
|
use xso::error::{Error, FromElementError};
|
|
|
|
#[cfg(target_pointer_width = "32")]
|
|
#[test]
|
|
fn test_size() {
|
|
assert_size!(Nick, 12);
|
|
}
|
|
|
|
#[cfg(target_pointer_width = "64")]
|
|
#[test]
|
|
fn test_size() {
|
|
assert_size!(Nick, 24);
|
|
}
|
|
|
|
#[test]
|
|
fn test_simple() {
|
|
let elem: Element = "<nick xmlns='http://jabber.org/protocol/nick'>Link Mauve</nick>"
|
|
.parse()
|
|
.unwrap();
|
|
let nick = Nick::try_from(elem).unwrap();
|
|
assert_eq!(&nick.0, "Link Mauve");
|
|
}
|
|
|
|
#[test]
|
|
fn test_serialise() {
|
|
let elem1 = Element::from(Nick(String::from("Link Mauve")));
|
|
let elem2: Element = "<nick xmlns='http://jabber.org/protocol/nick'>Link Mauve</nick>"
|
|
.parse()
|
|
.unwrap();
|
|
assert_eq!(elem1, elem2);
|
|
}
|
|
|
|
#[cfg(feature = "pedantic")]
|
|
#[test]
|
|
fn test_invalid() {
|
|
let elem: Element = "<nick xmlns='http://jabber.org/protocol/nick'><coucou/></nick>"
|
|
.parse()
|
|
.unwrap();
|
|
let error = Nick::try_from(elem).unwrap_err();
|
|
let message = match error {
|
|
FromElementError::Invalid(Error::Other(string)) => string,
|
|
_ => panic!(),
|
|
};
|
|
assert_eq!(message, "Unknown child in Nick element.");
|
|
}
|
|
|
|
#[cfg(feature = "pedantic")]
|
|
#[test]
|
|
fn test_invalid_attribute() {
|
|
let elem: Element = "<nick xmlns='http://jabber.org/protocol/nick' coucou=''/>"
|
|
.parse()
|
|
.unwrap();
|
|
let error = Nick::try_from(elem).unwrap_err();
|
|
let message = match error {
|
|
FromElementError::Invalid(Error::Other(string)) => string,
|
|
_ => panic!(),
|
|
};
|
|
assert_eq!(message, "Unknown attribute in Nick element.");
|
|
}
|
|
}
|