xmpp-rs/xso-proc
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Jonas Schäfer 9fdb1564f6 xso: reject attempts to match the same XML attribute in different fields
This was a bit tricky to build, because it is possible to have an
indirection through a `static` there. Thanks to Rust's extensive
const-fn capabilities, though, it's in fact possible to cover all cases.

We still do two different checks to improve user experience. If we can,
from within the proc macro, determine that two fields refer to the same
XML attribute (because their namespace/name values use the same Rust
tokens), then we reject the fields with a clear error message pointing
at both fields.

In the other case, when there's e.g. `#[xml(lang)]` and
`#[xml(attribute(namespace = rxml::XMLNS_XML, name = "lang"))]`, the
macro cannot be sure that XMLNS_XML is in fact the XML namespace. For
that case, we generate code which is evaluated at compile time (and
has no runtime impact) which panics if the namespace and name of two
attribute-matching fields is the same.

The error message will be less clear (because it contains extra,
unchangeable wording like "evaluation of constant value failed" and "the
evaluated program panicked at", which may be a bit confusing) than the
message generated by the macros themselves, but it's a price we have to
pay unfortunately.

Note that this check may seem cosmetic and purely for better user
experience, but it is in fact needed to avoid generating not-well-formed
and/or not-namespace-well-formed XML: As `AsXml` generates `xso::Item`,
where each attribute is emitted separated (and not aggregated in a
map structure), a naive (and efficient) implementation of a writer might
not double-check that no duplicate attributes are generated.
2025-04-27 11:18:50 +02:00
..
src xso: reject attempts to match the same XML attribute in different fields 2025-04-27 11:18:50 +02:00
Cargo.toml xso: reject attempts to match the same XML attribute in different fields 2025-04-27 11:18:50 +02:00
ChangeLog xso-proc: add support for child elements 2024-07-26 22:31:42 +02:00
README.md xso: add README files 2024-07-24 16:27:53 +02:00

xso_proc -- derive macros for XML parsing

Whats this?

This crate provides the derive macros exported by the xso crate. Please see that crate's README and documentation for more information.

What license is it under?

MPL-2.0 or later, see the LICENSE file.