xmppftw/xmpp-rs
Watch
1
0
Fork
You've already forked xmpp-rs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

xmpp-parsers: Reduce component handshake allocations

Browse source 
This function always appends to an existing string, so by passing it a
String directly we can avoid superfluous allocations.

Also tokio-xmpp was doing a bunch of &str to String for no reason around
there, let’s remove that too.
This commit is contained in:
Emmanuel Gil Peyrot 2025-02-10 15:30:08 +01:00 • committed by pep
commit c497967b1c
4 changed files with 14 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
parsers/src/component.rs
View file

@ -31,8 +31,8 @@ impl Handshake {
}
/// Creates an authentication request from the component.
pub fn from_password_and_stream_id(password: &str, stream_id: &str) -> Handshake {
let input = String::from(stream_id) + password;
pub fn from_stream_id_and_password(stream_id: String, password: &str) -> Handshake {
let input = stream_id + password;
let hash = Sha1::digest(input.as_bytes());
Handshake {
data: Some(hash.into()),
@ -76,7 +76,9 @@ mod tests {
let handshake = Handshake::new();
assert_eq!(handshake.data, None);
let handshake = Handshake::from_password_and_stream_id("123456", "sid");
let stream_id = String::from("sid");
let password = "123456";
let handshake = Handshake::from_stream_id_and_password(stream_id, password);
assert_eq!(
handshake.data,
Some([