xmppftw/xmpp-rs
Watch
1
0
Fork
You've already forked xmpp-rs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make comments optional.

Browse source 
Add a default "comments" feature to transform comments into errors when
unset.

This is so that XMPP implementations don’t have to care about comments,
as they can’t happen in the stream.
This commit is contained in:
Emmanuel Gil Peyrot 2019-08-22 18:04:47 +02:00
commit a91252c861
6 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/element.rs
View file

@ -283,9 +283,14 @@ impl Element {
Event::Eof => {
return Err(Error::EndOfDocument);
},
#[cfg(not(feature = "comments"))]
Event::Comment { .. } => {
return Err(Error::CommentsDisabled);
}
#[cfg(feature = "comments")]
Event::Comment { .. } => (),
Event::Text { .. } |
Event::End { .. } |
Event::Comment { .. } |
Event::CData { .. } |
Event::Decl { .. } |
Event::PI { .. } |
@ -361,6 +366,9 @@ impl Element {
Event::Eof => {
break;
},
#[cfg(not(feature = "comments"))]
Event::Comment(_) => return Err(Error::CommentsDisabled),
#[cfg(feature = "comments")]
Event::Comment(s) => {
let comment = reader.decode(&s).into_owned();
if comment != "" {
@ -569,6 +577,7 @@ impl Element {
///
/// elem.append_comment_node("comment");
/// ```
#[cfg(feature = "comments")]
pub fn append_comment_node<S: Into<String>>(&mut self, child: S) {
self.children.push(Node::Comment(child.into()));
}