xmppftw/xmpp-rs
Watch
1
0
Fork
You've already forked xmpp-rs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

minidom: Make ElementBuilder::prefix fail on adding duplicate prefix

Browse source 
Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>
This commit is contained in:
Maxime “pep” Buquet 2020-03-29 21:35:53 +02:00
commit 937e2380b9
3 changed files with 21 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

10
minidom-rs/src/element.rs
View file

@ -194,7 +194,7 @@ impl Element {
name.into(),
namespace.into(),
None,
BTreeMap::new(),
None,
BTreeMap::new(),
Vec::new(),
)
@ -987,10 +987,12 @@ pub struct ElementBuilder {
impl ElementBuilder {
/// Sets a custom prefix. It is not possible to set the same prefix twice.
pub fn prefix<S: Into<Namespace>>(mut self, prefix: Prefix, namespace: S) -> ElementBuilder {
// TODO: Make this actually send back an error when a duplicate prefix is added.
pub fn prefix<S: Into<Namespace>>(mut self, prefix: Prefix, namespace: S) -> Result<ElementBuilder> {
if let Some(_) = self.root.prefixes.get(&prefix) {
return Err(Error::DuplicatePrefix);
}
self.root.prefixes.insert(prefix, namespace.into());
self
Ok(self)
}
/// Sets an attribute.