xmppftw/xmpp-rs
Watch
1
0
Fork
You've already forked xmpp-rs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

xmpp-parsers: Fix most of the clippy warnings

Browse source 
Only the non-looping loop is kept for now, until we find a better
solution.
This commit is contained in:
Emmanuel Gil Peyrot 2024-07-03 11:06:33 +02:00
commit 69f480e709
8 changed files with 29 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

18
parsers/src/vcard.rs
View file

@ -62,7 +62,9 @@ impl TryFrom<Element> for VCard {
fn try_from(value: Element) -> Result<Self, Self::Error> {
// Check that the root element is <vCard>
if !value.is("vCard", ns::VCARD) {
return Err(Error::Other("Root element is not <vCard xmlns='vcard-temp'>").into());
return Err(Error::Other(
"Root element is not <vCard xmlns='vcard-temp'>",
));
}
// Parse the <PHOTO> element, if any.
@ -76,15 +78,11 @@ impl TryFrom<Element> for VCard {
}
}
impl Into<Element> for VCard {
fn into(self) -> Element {
let mut builder = Element::builder("vCard", ns::VCARD);
if let Some(photo) = self.photo {
builder = builder.append(photo);
}
builder.build()
impl From<VCard> for Element {
fn from(vcard: VCard) -> Element {
Element::builder("vCard", ns::VCARD)
.append_all(vcard.photo)
.build()
}
}