xso: clippy run

Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>

xso/src/asxml.rs

@@ -104,7 +104,7 @@ where
 /// Provides a helper which implements Display printing raw XML
 pub struct PrintRawXml<'x, T>(pub &'x T);
 
-impl<'x, T: AsXml> fmt::Display for PrintRawXml<'x, T> {
+impl<T: AsXml> fmt::Display for PrintRawXml<'_, T> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let iter = match self.0.as_xml_iter() {
             Ok(iter) => iter,

xso/src/fromxml.rs

@@ -311,7 +311,7 @@ pub struct Empty {
 #[cfg(feature = "macros")]
 impl Empty {
     pub fn start(self, attr: rxml::AttrMap) -> Result<EmptyBuilder, Error> {
-        if attr.len() > 0 {
+        if !attr.is_empty() {
             return Err(Error::Other(self.attributeerr));
         }
         Ok(EmptyBuilder {

xso/src/minidom_compat.rs

@@ -195,7 +195,7 @@ impl<'a> Iterator for ElementAsXml<'a> {
     fn next(&mut self) -> Option<Self::Item> {
         match self.0 {
             None => None,
-            Some(AsXmlState::Header { ref element }) => {
+            Some(AsXmlState::Header { element }) => {
                 let item = Item::ElementHeadStart(
                     Namespace::from(element.ns()),
                     Cow::Borrowed(match <&NcNameStr>::try_from(element.name()) {
@@ -214,7 +214,7 @@ impl<'a> Iterator for ElementAsXml<'a> {
             }
             Some(AsXmlState::Attributes {
                 ref mut attributes,
-                ref element,
+                element,
             }) => {
                 if let Some((name, value)) = attributes.next() {
                     let name = match <&NameStr>::try_from(name) {
@@ -282,7 +282,7 @@ impl<'a> Iterator for ElementAsXml<'a> {
                             Ok(v) => v,
                             Err(e) => {
                                 self.0 = None;
-                                return Some(Err(e.into()));
+                                return Some(Err(e));
                             }
                         };
                         let item = iter.next().unwrap();
@@ -445,7 +445,7 @@ pub struct AsItemsViaElement<'x> {
     lifetime_binding: PhantomData<Item<'x>>,
 }
 
-impl<'x> AsItemsViaElement<'x> {
+impl AsItemsViaElement<'_> {
     /// Create a new streaming parser for `T`.
     pub fn new<E, T>(value: T) -> Result<Self, crate::error::Error>
     where

xso/src/text.rs

@@ -312,7 +312,7 @@ impl TextCodec<Vec<u8>> for Base64 {
     fn encode<'x>(&self, value: &'x Vec<u8>) -> Result<Option<Cow<'x, str>>, Error> {
         Ok(Some(Cow::Owned(base64::engine::Engine::encode(
             &StandardBase64Engine,
-            &value,
+            value,
         ))))
     }
 }
@@ -328,7 +328,7 @@ impl<'x> TextCodec<Cow<'x, [u8]>> for Base64 {
     fn encode<'a>(&self, value: &'a Cow<'x, [u8]>) -> Result<Option<Cow<'a, str>>, Error> {
         Ok(Some(Cow::Owned(base64::engine::Engine::encode(
             &StandardBase64Engine,
-            &value,
+            value,
         ))))
     }
 }
@@ -362,13 +362,13 @@ impl<T: base64::engine::Engine> TextCodec<Vec<u8>> for T {
 
     fn encode<'x>(&self, value: &'x Vec<u8>) -> Result<Option<Cow<'x, str>>, Error> {
         Ok(Some(Cow::Owned(base64::engine::Engine::encode(
-            self, &value,
+            self, value,
         ))))
     }
 }
 
 #[cfg(feature = "base64")]
-impl<'a, T: base64::engine::Engine, U> TextCodec<Option<U>> for T
+impl<T: base64::engine::Engine, U> TextCodec<Option<U>> for T
 where
     T: TextCodec<U>,
 {