unescape_and_decode_value for element attributes

This commit is contained in:
Johann Tuffe 2017-07-08 12:18:15 +08:00
commit 444b78c63a
2 changed files with 17 additions and 17 deletions

View file

@ -4,7 +4,7 @@ minidom-rs
What's this?
------------
A minimal DOM library on top of xml-rs.
A minimal DOM library on top of quick-xml.
What license is it under?
-------------------------

View file

@ -253,7 +253,7 @@ impl Element {
let e = reader.read_event(&mut buf)?;
match e {
Event::Empty(ref e) | Event::Start(ref e) => {
root = build_element(e)?; // FIXME: could be break build_element(e)? when break value is stable
root = build_element(&reader, e)?; // FIXME: could be break build_element(e)? when break value is stable
break;
},
Event::Eof => {
@ -268,12 +268,12 @@ impl Element {
loop {
match reader.read_event(&mut buf)? {
Event::Empty(ref e) => {
let elem = build_element(e)?;
let elem = build_element(&reader, e)?;
// Since there is no Event::End after, directly append it to the current node
stack.last_mut().unwrap().append_child(elem);
},
Event::Start(ref e) => {
let elem = build_element(e)?;
let elem = build_element(&reader, e)?;
stack.push(elem);
},
Event::End(ref e) => {
@ -590,12 +590,12 @@ impl Element {
}
}
fn build_element(event: &BytesStart) -> Result<Element> {
fn build_element<R: BufRead>(reader: &EventReader<R>, event: &BytesStart) -> Result<Element> {
let mut attributes = event.attributes()
.map(|o| {
let o = o?;
let key = str::from_utf8(o.key)?.to_owned();
let value = str::from_utf8(o.value)?.to_owned();
let value = o.unescape_and_decode_value(reader)?;
Ok((key, value))
}
)