xmppftw/xmpp-rs
Watch
1
0
Fork
You've already forked xmpp-rs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

xmpp-parsers: Switch from zero-sized types to #[xml(flag)]

Browse source 
That way we can simply use true/false, instead of
Some(TheZeroSizedType)/None.
This commit is contained in:
Emmanuel Gil Peyrot 2025-01-25 19:39:49 +01:00
commit 244a9bbbf2
6 changed files with 19 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

13
parsers/src/sm.rs
View file

@ -133,21 +133,14 @@ pub struct Resumed {
pub previd: StreamId,
}
/// Marker whose presence indicates that negotiating stream management is
/// optional.
#[derive(FromXml, AsXml, PartialEq, Debug, Clone)]
#[xml(namespace = ns::SM, name = "optional")]
pub struct Optional;
// TODO: add support for optional and required.
/// Represents availability of Stream Management in `<stream:features/>`.
#[derive(FromXml, AsXml, PartialEq, Debug, Clone)]
#[xml(namespace = ns::SM, name = "sm")]
pub struct StreamManagement {
// TODO: replace with #[xml(flag)] once we have it.
/// `<optional/>` flag.
#[xml(child(default))]
pub optional: Option<Optional>,
#[xml(flag(name = "optional"))]
pub optional: bool,
}
/// Application-specific error condition to use when the peer acknowledges
@ -230,7 +223,6 @@ mod tests {
assert_size!(Resume, 16);
assert_size!(Resumed, 16);
assert_size!(StreamManagement, 1);
assert_size!(Optional, 0);
assert_size!(HandledCountTooHigh, 8);
}
@ -246,7 +238,6 @@ mod tests {
assert_size!(Resume, 32);
assert_size!(Resumed, 32);
assert_size!(StreamManagement, 1);
assert_size!(Optional, 0);
assert_size!(HandledCountTooHigh, 8);
}