xmppftw/xmpp-rs
Watch
1
0
Fork
You've already forked xmpp-rs
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

minidom: Implement PartialEq manually for Node and Element

Browse source 
Move the NamespaceAwareCompare implementation from xmpp-parsers as Node
and Element's PartialEq implementation. Thanks Astro!

It's a lot more useful in tests to use `assert_eq!` than `assert!`, so
we get both items compared (left and right) instead of a "it failed."
message.

This "breaks" comparison for these two structs in the sense that it is
not strict object comparison anymore but it ensures that namespaces are
all present in the compared objects.

Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>
This commit is contained in:
Maxime “pep” Buquet 2019-11-29 14:33:17 +01:00
commit 1c5551a917
No known key found for this signature in database
GPG key ID: DEDA74AEECA9D0F2
20 changed files with 65 additions and 172 deletions
Download patch file Download diff file Expand all files Collapse all files

4
minidom-rs/CHANGELOG.md
View file

@ -1,6 +1,8 @@
Version XXX, released YYY:
* Breaking
`Element.write_to` doesn't prepand xml prelude anymore. Use `write_to_decl`.
* `Element.write_to` doesn't prepand xml prelude anymore. Use `write_to_decl`.
* PartialEq implementation for Element and Node have been changed to
ensure namespaces match even if the objects are slightly different.
* Changes
* Update edition to 2018
* Add NSChoice enum to allow comparing NSs differently