c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
ooni-probe-cli/internal/engine
History
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Simone Basso fbee736e90
 fix(geolocate): no proxy when discovering our IP address (#251) 
* fix(geolocate): no proxy when discovering our IP address

The use case of --proxy is that you cannot contact the OONI
backend otherwise. It is wrong, though, using the proxy when
discovering our IP address. The measurement won't use the
proxy anyway. Therefore, we need to use the IP address that
is performing the measurement. Not the one of the proxy.

What's more, stun is not using a proxy. Therefore, it does
not make much sense that http IP resolvers use a proxy. This
leads to inconsistencies. So, here's anothe reason why this
patch is a good thing (TM).

Finally, because knowing the IP address enables us to sanitize
the data, it's important we discover the correct IP.

Now, up until this point, the `--proxy` option has mostly
been a developers toy. But, users have asked us to have the
possibility of configuring a proxy.

This explains why I have been looking into making `--proxy`
right for a couple of hours now.

See https://github.com/ooni/probe/issues/1382

* fix(session): properly configure the IP lookupper
2021-03-10 12:01:08 +01:00
..
atomicx chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experiment fix(webconnectivity): allow measuring https://1.1.1.1 (#241) 2021-03-08 12:05:43 +01:00
geolocate fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
httpheader Release 3.6.0 (#239) 2021-03-03 14:42:17 +01:00
httpx refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
humanizex refactor: miniooni should be outside of the engine (#206) 2021-02-03 11:21:10 +01:00
internal fix(sessionresolver): honour the proxy (#250) 2021-03-10 10:39:57 +01:00
kvstore refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
legacy Release 3.6.0 (#239) 2021-03-03 14:42:17 +01:00
model chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
netx fix(webconnectivity): allow measuring https://1.1.1.1 (#241) 2021-03-08 12:05:43 +01:00
ooapi engine/ooapi: autogenerated API with login and caching (#234) 2021-03-04 11:51:07 +01:00
probeservices refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
resources Release 3.6.0 (#239) 2021-03-03 14:42:17 +01:00
resourcesmanager Release 3.6.0 (#239) 2021-03-03 14:42:17 +01:00
runtimex refactor: start building an Android package (#205) 2021-02-03 10:51:14 +01:00
shellx fix: use golang.org/x/sys/execabs (#224) 2021-02-10 07:40:48 +01:00
testdata fix: add missing files causing tests to fail (#202) 2021-02-02 14:18:22 +01:00
.gitignore refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
allexperiments.go MVP of a signal messenger test (#230) 2021-02-26 10:16:34 +01:00
experiment.go fix: always use probe-cli version (and make it alpha) (#219) 2021-02-04 11:00:27 +01:00
experiment_integration_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experiment_internal_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experiment_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experimentbuilder.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experimentbuilder_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
inputloader.go MVP of a signal messenger test (#230) 2021-02-26 10:16:34 +01:00
inputloader_integration_test.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
inputloader_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
inputprocessor.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
inputprocessor_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
kvstore.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
kvstore_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
saver.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
saver_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
session.go fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
session_integration_test.go Release 3.6.0 (#239) 2021-03-03 14:42:17 +01:00
session_internal_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
submitter.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
submitter_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00