ooni-probe-cli/internal/engine/experiment/urlgetter
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Simone Basso bf3c8bcdc3
[forwardport] fix(netx): stop collecting HTTP performance metrics (#689)
This diff forward ports b6db4f64dc83a2a27ee3ce6bba5ac93db922832d, whose
original log message is the following:

- - -

We're now using ooni/oohttp as our HTTP library in most cases.

A limitation of this library is that net/http/httptrace does not
work very well and reliably because (1) we need to use oohttp's
version of that code and (2) we cannot observe net events.

I noticed this fact because an integration test for collecting
HTTP performance metrics was broken.

The best solution here is to remove this functionality, since
it was basically unused in the repository. Only some integration
tests inside urlgetter bothered with these metrics.

A more clinical fix would have been to use ooni/oohttp/httptrace
instead of net/http/httptrace in the stdlib, but it does not
seem to be a good idea, given that those metrics were not used.

With this diff applied, we'll further reduce the number of locally
failing integration tests to just jafar-specific tests.

This diff WILL need to be forwardported to `master`.
2022-02-09 15:08:19 +01:00
..
.gitignore chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
configurer.go cleanup(netx): remove the DNSClient type (#660) 2022-01-10 11:53:06 +01:00
configurer_test.go cleanup(netx): remove more legacy names and functions (#658) 2022-01-07 20:02:19 +01:00
getter.go feat(torsf): collect tor logs, select rendezvous method, count bytes (#683) 2022-02-07 17:05:36 +01:00
getter_integration_test.go [forwardport] fix(netx): stop collecting HTTP performance metrics (#689) 2022-02-09 15:08:19 +01:00
getter_test.go feat: tutorial on how to write the torsf experiment (#390) 2021-06-22 00:12:03 +02:00
multi.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
multi_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
runner.go refactor: merge dnsx and errorsx into netxlite (#517) 2021-09-28 12:42:01 +02:00
runner_test.go fix(netxlite): robust {ReadAll,Copy}Context with wrapped io.EOF (#661) 2022-01-12 14:26:10 +01:00
urlgetter.go fix: ensure experiments return nil when we want to submit (#654) 2022-01-07 13:17:20 +01:00
urlgetter_test.go fix: ensure experiments return nil when we want to submit (#654) 2022-01-07 13:17:20 +01:00