Simone Basso
acef18a955
fix(netx): repair BogonResolver tests ( #401 )
...
The BogonResolver relied on its wrapper resolver to pass along the
list of addresses _and_ the error. But the idiomatic thing to do is
often to return `nil` when there is an error.
I broke this very fragile assumption in https://github.com/ooni/probe-cli/pull/399 .
I could of course fix it, but this assumption is clearly wrong
and we should not allow such fragile code in the tree.
We are not using BogonIsError much in the tree. The only place in
which we're using it for measuring seems to be dnscheck.
It may be that this surprising behavior was what caused the issue at
https://github.com/ooni/probe/issues/1510 in the first place.
Regardless, let's remove fragile code and adjust the test that was
failing. Also that test is quick so it can run in `-short` mode.
Spotted while working on https://github.com/ooni/probe/issues/1505 .
2021-06-25 11:51:10 +02:00
..
experiment
refactor: move tls handshaker to netxlite ( #400 )
2021-06-25 11:07:26 +02:00
geolocate
cleanup(all): stop using deprecated ioutil functions ( #381 )
2021-06-15 14:01:45 +02:00
httpheader
Release 3.10.0 beta.3 ( #345 )
2021-05-13 08:16:28 +02:00
httpx
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
internal
refactor: move bytecounter to internal ( #391 )
2021-06-22 13:00:29 +02:00
legacy
refactor: move tls handshaker to netxlite ( #400 )
2021-06-25 11:07:26 +02:00
mockable
feat: tutorial on how to write the torsf experiment ( #390 )
2021-06-22 00:12:03 +02:00
model
refactor: move scrubbingLogger to the scrubber pkg ( #394 )
2021-06-22 14:43:58 +02:00
netx
fix(netx): repair BogonResolver tests ( #401 )
2021-06-25 11:51:10 +02:00
probeservices
feat: tutorial on how to write the torsf experiment ( #390 )
2021-06-22 00:12:03 +02:00
testdata
fix: add missing files causing tests to fail ( #202 )
2021-02-02 14:18:22 +01:00
.gitignore
feat: support embedding encrypted psiphon config ( #285 )
2021-04-02 17:36:06 +02:00
allexperiments.go
feat(torsf): experiment that bootstraps tor using snowflake ( #387 )
2021-06-18 13:51:18 +02:00
experiment.go
refactor: move bytecounter to internal ( #391 )
2021-06-22 13:00:29 +02:00
experiment_integration_test.go
refactor(inputloader): better docs and naming ( #265 )
2021-03-26 09:34:27 +01:00
experiment_internal_test.go
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
experiment_test.go
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
experimentbuilder.go
refactor(inputloader): better docs and naming ( #265 )
2021-03-26 09:34:27 +01:00
experimentbuilder_test.go
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
inputloader.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
inputloader_network_test.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
inputloader_test.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
inputprocessor.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
inputprocessor_test.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
kvstore.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
saver.go
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
saver_test.go
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
session.go
refactor: move bytecounter to internal ( #391 )
2021-06-22 13:00:29 +02:00
session_integration_test.go
cleanup(all): stop using deprecated ioutil functions ( #381 )
2021-06-15 14:01:45 +02:00
session_internal_test.go
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
session_nopsiphon.go
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
session_nopsiphon_test.go
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
session_psiphon.go
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
session_psiphon_test.go
feat: support embedding encrypted psiphon config ( #285 )
2021-04-02 17:36:06 +02:00
submitter.go
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
submitter_test.go
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00