c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
ooni-probe-cli/internal/engine/netx/quicdialer
History
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Simone Basso a4d61a4be4
 fix(netxlite): close quic packetconn (#407) 
Noticed when working on https://github.com/ooni/probe/issues/1505.

Justification for this diff:

1. [DialEarlyContext calls dialContext with the last argument set to false](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L153);

2. [the semantics of the last argument is whether we own the connection](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L187);

3. [this value is propagated to the client data structure](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L269);

4. [client.dial](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L302) runs the session in a background goroutine and only destroys the `packetHandlers` when the connection is owned;

5. [packetHandlerMap.Destroy](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/packet_handler_map.go#L293) closes the underlying PacketConn.

6. also, the documentation clearly states that when you use `DialEarlyContext` you can use the same packet conn multiple times, so it does not take ownership.
2021-06-25 17:58:42 +02:00
..
connectionstate.go release process: update dependencies (#280) 2021-03-31 16:40:58 +02:00
dns.go refactor: start pivoting netx (#396) 2021-06-23 15:53:12 +02:00
dns_test.go refactor: move quicdialing base functionality to netxlite (#406) 2021-06-25 17:04:24 +02:00
errorwrapper.go cleanup: remove ConnID, DialID, TransactionID (#395) 2021-06-23 13:36:45 +02:00
errorwrapper_test.go refactor: move quicdialing base functionality to netxlite (#406) 2021-06-25 17:04:24 +02:00
quicdialer.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
saver.go refactor: merge tlsx into netxlite (#403) 2021-06-25 12:39:45 +02:00
saver_test.go refactor: move quicdialing base functionality to netxlite (#406) 2021-06-25 17:04:24 +02:00
system.go fix(netxlite): close quic packetconn (#407) 2021-06-25 17:58:42 +02:00
system_test.go refactor: move quicdialing base functionality to netxlite (#406) 2021-06-25 17:04:24 +02:00