Simone Basso
0fdc9cafb5
fix(all): introduce and use iox.ReadAllContext ( #379 ) ...
* fix(all): introduce and use iox.ReadAllContext
This improvement over the ioutil.ReadAll utility returns early
if the context expires. This enables us to unblock stuck code in
case there's censorship confounding the TCP stack.
See https://github.com/ooni/probe/issues/1417 .
Compared to the functionality postulated in the above mentioned
issue, I choose to be more generic and separate limiting the
maximum body size (not implemented here) from using the context
to return early when reading a body (or any other reader).
After implementing iox.ReadAllContext, I made sure we always
use it everywhere in the tree instead of ioutil.ReadAll.
This includes many parts of the codebase where in theory we don't
need iox.ReadAllContext. Though, changing all the places makes
checking whether we're not using ioutil.ReadAll where we should
not be using it easy: `git grep` should return no lines.
* Update internal/iox/iox_test.go
* fix(ndt7): treat context errors as non-errors
The rationale is explained by the comment documenting reduceErr.
* Update internal/engine/experiment/ndt7/download.go
2021-06-15 11:57:40 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
Release 3.10.0 beta.3 ( #345 )
2021-05-13 08:16:28 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
geolocate: first pass of code review and minor fixes ( #359 )
2021-06-04 16:06:24 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
fix: add missing files causing tests to fail ( #202 )
2021-02-02 14:18:22 +01:00
feat: support embedding encrypted psiphon config ( #285 )
2021-04-02 17:36:06 +02:00
refactor(inputloader): better docs and naming ( #265 )
2021-03-26 09:34:27 +01:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
refactor(inputloader): better docs and naming ( #265 )
2021-03-26 09:34:27 +01:00
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
refactor(inputloader): better docs and naming ( #265 )
2021-03-26 09:34:27 +01:00
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
geolocate: first pass of code review and minor fixes ( #359 )
2021-06-04 16:06:24 +02:00
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
fix(session): make sure tunnel code is tested ( #301 )
2021-04-05 19:51:41 +02:00
fix(all): introduce and use iox.ReadAllContext ( #379 )
2021-06-15 11:57:40 +02:00
feat: support embedding encrypted psiphon config ( #285 )
2021-04-02 17:36:06 +02:00
chore: merge probe-engine into probe-cli ( #201 )
2021-02-02 12:05:47 +01:00
refactor: flatten and separate ( #353 )
2021-06-04 10:34:18 +02:00
0fdc9cafb5