fix(webconnectivity): expose network events (#258)
* fix(webconnectivity): expose network events By not exposing network events in webconnectivity, we are missing several interesting, explanatory data points. This diff fixes the issue by: 1. enriching the definition of network events to include extra data useful for performing (manual) data analysis; 2. adding a tags field to network events such that we can add tags to specific events and understand where they come from; 3. exposing all the (tagged) network events that happen when running a webconnectivity experiment. See https://github.com/ooni/probe-engine/issues/1157. * progress * more work towards landing this diff * Apply suggestions from code review
This commit is contained in:
parent
70d7c1a22c
commit
fc19c9901a
6 changed files with 67 additions and 16 deletions
|
|
@ -6,6 +6,7 @@ import (
|
|||
"net"
|
||||
"net/url"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/ooni/probe-cli/v3/internal/engine/experiment/urlgetter"
|
||||
"github.com/ooni/probe-cli/v3/internal/engine/model"
|
||||
|
|
@ -14,6 +15,7 @@ import (
|
|||
// HTTPGetConfig contains the config for HTTPGet
|
||||
type HTTPGetConfig struct {
|
||||
Addresses []string
|
||||
Begin time.Time
|
||||
Session model.ExperimentSession
|
||||
TargetURL *url.URL
|
||||
}
|
||||
|
|
@ -54,6 +56,7 @@ func HTTPGet(ctx context.Context, config HTTPGetConfig) (out HTTPGetResult) {
|
|||
config.Session.Logger().Infof("GET %s...", target)
|
||||
domain := config.TargetURL.Hostname()
|
||||
result, err := urlgetter.Getter{
|
||||
Begin: config.Begin,
|
||||
Config: urlgetter.Config{
|
||||
DNSCache: HTTPGetMakeDNSCache(domain, addresses),
|
||||
},
|
||||
|
|
|
|||
Loading…
Reference in a new issue