c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(geolocate): no proxy when discovering our IP address (#251)

Browse source 
* fix(geolocate): no proxy when discovering our IP address

The use case of --proxy is that you cannot contact the OONI
backend otherwise. It is wrong, though, using the proxy when
discovering our IP address. The measurement won't use the
proxy anyway. Therefore, we need to use the IP address that
is performing the measurement. Not the one of the proxy.

What's more, stun is not using a proxy. Therefore, it does
not make much sense that http IP resolvers use a proxy. This
leads to inconsistencies. So, here's anothe reason why this
patch is a good thing (TM).

Finally, because knowing the IP address enables us to sanitize
the data, it's important we discover the correct IP.

Now, up until this point, the `--proxy` option has mostly
been a developers toy. But, users have asked us to have the
possibility of configuring a proxy.

This explains why I have been looking into making `--proxy`
right for a couple of hours now.

See https://github.com/ooni/probe/issues/1382

* fix(session): properly configure the IP lookupper
This commit is contained in:
Simone Basso 2021-03-10 12:01:08 +01:00 • committed by GitHub
commit fbee736e90
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 56 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

17
internal/engine/geolocate/iplookup.go
View file

@ -11,6 +11,7 @@ import (
"time"
"github.com/ooni/probe-cli/v3/internal/engine/internal/multierror"
"github.com/ooni/probe-cli/v3/internal/engine/netx"
)
var (
@ -65,8 +66,8 @@ var (
)
type ipLookupClient struct {
// HTTPClient is the HTTP client to use
HTTPClient *http.Client
// Resolver is the resolver to use for HTTP.
Resolver Resolver
// Logger is the logger to use
Logger Logger
@ -88,7 +89,15 @@ func makeSlice() []method {
func (c ipLookupClient) doWithCustomFunc(
ctx context.Context, fn lookupFunc,
) (string, error) {
ip, err := fn(ctx, c.HTTPClient, c.Logger, c.UserAgent)
// Implementation note: we MUST use an HTTP client that we're
// sure IS NOT using any proxy. To this end, we construct a
// client ourself that we know is not proxied.
clnt := &http.Client{Transport: netx.NewHTTPTransport(netx.Config{
Logger: c.Logger,
FullResolver: c.Resolver,
})}
defer clnt.CloseIdleConnections()
ip, err := fn(ctx, clnt, c.Logger, c.UserAgent)
if err != nil {
return DefaultProbeIP, err
}
@ -102,7 +111,7 @@ func (c ipLookupClient) doWithCustomFunc(
func (c ipLookupClient) LookupProbeIP(ctx context.Context) (string, error) {
union := multierror.New(ErrAllIPLookuppersFailed)
for _, method := range makeSlice() {
c.Logger.Debugf("iplookup: using %s", method.name)
c.Logger.Infof("iplookup: using %s", method.name)
ip, err := c.doWithCustomFunc(ctx, method.fn)
if err == nil {
return ip, nil