geolocate: first pass of code review and minor fixes (#359)
* doc(geolocate): minor cleanup * more minor cleanups of geolocate * remove disabled test and see whether now it works
This commit is contained in:
parent
3cb6c7c6fb
commit
f271e71c0b
7 changed files with 29 additions and 38 deletions
|
|
@ -4,7 +4,6 @@ import (
|
|||
"context"
|
||||
"net"
|
||||
"net/http"
|
||||
"os"
|
||||
"testing"
|
||||
|
||||
"github.com/apex/log"
|
||||
|
|
@ -12,11 +11,6 @@ import (
|
|||
)
|
||||
|
||||
func TestIPLookupWorksUsingIPConfig(t *testing.T) {
|
||||
if os.Getenv("CI") == "true" {
|
||||
// See https://github.com/ooni/probe-cli/pull/259/checks?check_run_id=2166066881#step:5:123
|
||||
// as well as https://github.com/ooni/probe/issues/1418.
|
||||
t.Skip("This test does not work with GitHub Actions")
|
||||
}
|
||||
ip, err := ipConfigIPLookup(
|
||||
context.Background(),
|
||||
http.DefaultClient,
|
||||
|
|
|
|||
Loading…
Reference in a new issue