refactor: i/errorsx is now i/legacy/errorsx (#479)

We need still to add similar wrappers to internal/netxlite but we
will adopt a saner approach to error wrapping this time.

See https://github.com/ooni/probe/issues/1591

internal/errorsx/integration_test.go

@@ -1,55 +0,0 @@
-package errorsx_test
-
-import (
-	"context"
-	"crypto/tls"
-	"testing"
-
-	"github.com/lucas-clemente/quic-go"
-	errorsxlegacy "github.com/ooni/probe-cli/v3/internal/errorsx"
-	"github.com/ooni/probe-cli/v3/internal/netxlite"
-	"github.com/ooni/probe-cli/v3/internal/netxlite/errorsx"
-)
-
-func TestErrorWrapperQUICDialerInvalidCertificate(t *testing.T) {
-	nextprotos := []string{"h3"}
-	servername := "example.com"
-	tlsConf := &tls.Config{
-		NextProtos: nextprotos,
-		ServerName: servername,
-	}
-
-	dlr := &errorsxlegacy.ErrorWrapperQUICDialer{Dialer: &netxlite.QUICDialerQUICGo{
-		QUICListener: &netxlite.QUICListenerStdlib{},
-	}}
-	// use Google IP
-	sess, err := dlr.DialContext(context.Background(), "udp",
-		"216.58.212.164:443", tlsConf, &quic.Config{})
-	if err == nil {
-		t.Fatal("expected an error here")
-	}
-	if sess != nil {
-		t.Fatal("expected nil sess here")
-	}
-	if err.Error() != errorsx.FailureSSLInvalidCertificate {
-		t.Fatal("unexpected failure")
-	}
-}
-
-func TestErrorWrapperQUICDialerSuccess(t *testing.T) {
-	ctx := context.Background()
-	tlsConf := &tls.Config{
-		NextProtos: []string{"h3"},
-		ServerName: "www.google.com",
-	}
-	d := &errorsxlegacy.ErrorWrapperQUICDialer{Dialer: &netxlite.QUICDialerQUICGo{
-		QUICListener: &netxlite.QUICListenerStdlib{},
-	}}
-	sess, err := d.DialContext(ctx, "udp", "216.58.212.164:443", tlsConf, &quic.Config{})
-	if err != nil {
-		t.Fatal(err)
-	}
-	if sess == nil {
-		t.Fatal("expected non-nil sess here")
-	}
-}