[forwardport] refactor(oonimkall): merge internal/task into oonimkall (#617) (#618)

This diff forward ports bc4b9f1ea89158bfa7b7a80ae59a90b43c784ed2 to `master`.

See https://github.com/ooni/probe/issues/1903

pkg/oonimkall/runner_internal_test.go

@@ -0,0 +1,76 @@
+package oonimkall
+
+import (
+	"context"
+	"errors"
+	"fmt"
+	"testing"
+
+	engine "github.com/ooni/probe-cli/v3/internal/engine"
+)
+
+func TestMeasurementSubmissionEventName(t *testing.T) {
+	if measurementSubmissionEventName(nil) != statusMeasurementSubmission {
+		t.Fatal("unexpected submission event name")
+	}
+	if measurementSubmissionEventName(errors.New("mocked error")) != failureMeasurementSubmission {
+		t.Fatal("unexpected submission event name")
+	}
+}
+
+func TestMeasurementSubmissionFailure(t *testing.T) {
+	if measurementSubmissionFailure(nil) != "" {
+		t.Fatal("unexpected submission failure")
+	}
+	if measurementSubmissionFailure(errors.New("mocked error")) != "mocked error" {
+		t.Fatal("unexpected submission failure")
+	}
+}
+
+func TestRunnerMaybeLookupLocationFailure(t *testing.T) {
+	if testing.Short() {
+		// TODO(https://github.com/ooni/probe-cli/pull/518)
+		t.Skip("skip test in short mode")
+	}
+	out := make(chan *event)
+	settings := &settings{
+		AssetsDir: "../../testdata/oonimkall/assets",
+		Name:      "Example",
+		Options: settingsOptions{
+			SoftwareName:    "oonimkall-test",
+			SoftwareVersion: "0.1.0",
+		},
+		StateDir: "../../testdata/oonimkall/state",
+		Version:  1,
+	}
+	seench := make(chan int64)
+	go func() {
+		var seen int64
+		for ev := range out {
+			switch ev.Key {
+			case "failure.ip_lookup", "failure.asn_lookup",
+				"failure.cc_lookup", "failure.resolver_lookup":
+				seen++
+			case "status.progress":
+				evv := ev.Value.(eventStatusProgress)
+				if evv.Percentage >= 0.2 {
+					panic(fmt.Sprintf("too much progress: %+v", ev))
+				}
+			case "status.queued", "status.started", "status.end":
+			default:
+				panic(fmt.Sprintf("unexpected key: %s - %+v", ev.Key, ev.Value))
+			}
+		}
+		seench <- seen
+	}()
+	expected := errors.New("mocked error")
+	r := newRunner(settings, out)
+	r.maybeLookupLocation = func(*engine.Session) error {
+		return expected
+	}
+	r.Run(context.Background())
+	close(out)
+	if n := <-seench; n != 4 {
+		t.Fatal("unexpected number of events")
+	}
+}