feat(httpx): implement optional body logging also on http error (#651)
1. we want optionally to log the body (we don't want to log the body when we're fetching psiphon secrets or tor targets) 2. we want body logging to _also_ happen on error since this is quite useful to debug possible errors when accessing the API This diff adds the above functionality, which were previously described in https://github.com/ooni/probe/issues/1951. This diff also adds comprehensive testing.
This commit is contained in:
parent
ee0aa18616
commit
dba861d262
13 changed files with 229 additions and 17 deletions
|
|
@ -9,6 +9,6 @@ import (
|
|||
// GetTestHelpers is like GetCollectors but for test helpers.
|
||||
func (c Client) GetTestHelpers(
|
||||
ctx context.Context) (output map[string][]model.OOAPIService, err error) {
|
||||
err = c.APIClientTemplate.Build().GetJSON(ctx, "/api/v1/test-helpers", &output)
|
||||
err = c.APIClientTemplate.WithBodyLogging().Build().GetJSON(ctx, "/api/v1/test-helpers", &output)
|
||||
return
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue