c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: merge probe-engine into probe-cli (#201)

Browse source 
This is how I did it:

1. `git clone https://github.com/ooni/probe-engine internal/engine`

2. ```
(cd internal/engine && git describe --tags)
v0.23.0
```

3. `nvim go.mod` (merging `go.mod` with `internal/engine/go.mod`

4. `rm -rf internal/.git internal/engine/go.{mod,sum}`

5. `git add internal/engine`

6. `find . -type f -name \*.go -exec sed -i 's@/ooni/probe-engine@/ooni/probe-cli/v3/internal/engine@g' {} \;`

7. `go build ./...` (passes)

8. `go test -race ./...` (temporary failure on RiseupVPN)

9. `go mod tidy`

10. this commit message

Once this piece of work is done, we can build a new version of `ooniprobe` that
is using `internal/engine` directly. We need to do more work to ensure all the
other functionality in `probe-engine` (e.g. making mobile packages) are still WAI.

Part of https://github.com/ooni/probe/issues/1335
This commit is contained in:
Simone Basso 2021-02-02 12:05:47 +01:00 • committed by GitHub
commit d57c78bc71
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
535 changed files with 66182 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

106
internal/engine/probeservices/metadata_test.go Normal file
View file

@ -0,0 +1,106 @@
package probeservices_test
import (
"testing"
"github.com/ooni/probe-cli/v3/internal/engine/probeservices"
)
func TestValid(t *testing.T) {
t.Run("fail on probe_cc", func(t *testing.T) {
var m probeservices.Metadata
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("fail on probe_asn", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
}
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("fail on platform", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
ProbeASN: "AS1234",
}
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("fail on software_name", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
ProbeASN: "AS1234",
Platform: "linux",
}
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("fail on software_version", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
ProbeASN: "AS1234",
Platform: "linux",
SoftwareName: "miniooni",
}
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("fail on supported_tests", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
ProbeASN: "AS1234",
Platform: "linux",
SoftwareName: "miniooni",
SoftwareVersion: "0.1.0-dev",
}
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("fail on missing device_token", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
ProbeASN: "AS1234",
Platform: "ios",
SoftwareName: "miniooni",
SoftwareVersion: "0.1.0-dev",
SupportedTests: []string{"web_connectivity"},
}
if m.Valid() != false {
t.Fatal("expected false here")
}
})
t.Run("success for desktop", func(t *testing.T) {
m := probeservices.Metadata{
ProbeCC: "IT",
ProbeASN: "AS1234",
Platform: "linux",
SoftwareName: "miniooni",
SoftwareVersion: "0.1.0-dev",
SupportedTests: []string{"web_connectivity"},
}
if m.Valid() != true {
t.Fatal("expected true here")
}
})
t.Run("success for mobile", func(t *testing.T) {
m := probeservices.Metadata{
DeviceToken: "xx-xxx-xx-xxxx",
ProbeCC: "IT",
ProbeASN: "AS1234",
Platform: "android",
SoftwareName: "miniooni",
SoftwareVersion: "0.1.0-dev",
SupportedTests: []string{"web_connectivity"},
}
if m.Valid() != true {
t.Fatal("expected true here")
}
})
}