feat(oonirun): improve tests (#915)

See https://github.com/ooni/probe/issues/2184

While there, rename `runtimex.PanicIfFalse` to `runtimex.Assert` (it was about time...)
This commit is contained in:
Simone Basso 2022-08-31 18:40:27 +02:00 committed by GitHub
commit d0da224a2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
32 changed files with 1837 additions and 112 deletions

View file

@ -104,7 +104,7 @@ func NewDefaultCertPool() *x509.CertPool {
// Assumption: AppendCertsFromPEM cannot fail because we
// have a test in certify_test.go that guarantees that
ok := pool.AppendCertsFromPEM([]byte(pemcerts))
runtimex.PanicIfFalse(ok, "pool.AppendCertsFromPEM failed")
runtimex.Assert(ok, "pool.AppendCertsFromPEM failed")
return pool
}