feat(oonirun): improve tests (#915)

See https://github.com/ooni/probe/issues/2184

While there, rename `runtimex.PanicIfFalse` to `runtimex.Assert` (it was about time...)

internal/engine/mockable/mockable.go

@@ -11,6 +11,8 @@ import (
 )
 
 // Session allows to mock sessions.
+//
+// Deprecated: use ./internal/model/mocks.Session instead.
 type Session struct {
 	MockableTestHelpers              map[string][]model.OOAPIService
 	MockableHTTPClient               model.HTTPClient

internal/engine/saver.go

@@ -6,10 +6,8 @@ import (
 	"github.com/ooni/probe-cli/v3/internal/model"
 )
 
-// Saver saves a measurement on some persistent storage.
-type Saver interface {
-	SaveMeasurement(m *model.Measurement) error
-}
+// Saver is an alias for model.Saver.
+type Saver = model.Saver
 
 // SaverConfig is the configuration for creating a new Saver.
 type SaverConfig struct {

internal/engine/submitter.go

@@ -9,12 +9,8 @@ import (
 // TODO(bassosimone): maybe keep track of which measurements
 // could not be submitted by a specific submitter?
 
-// Submitter submits a measurement to the OONI collector.
-type Submitter interface {
-	// Submit submits the measurement and updates its
-	// report ID field in case of success.
-	Submit(ctx context.Context, m *model.Measurement) error
-}
+// Submitter is an alias for model.Submitter
+type Submitter = model.Submitter
 
 // SubmitterSession is the Submitter's view of the Session.
 type SubmitterSession interface {