fix(reduceErrors): return error when given an empty list (#675)

See https://github.com/ooni/probe/issues/1985 for context.

While there, ensure nextlite has 100% of coverage.
This commit is contained in:
Simone Basso 2022-01-26 12:18:36 +01:00 committed by GitHub
commit ce8ec5b391
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 18 additions and 3 deletions

View file

@ -9,6 +9,9 @@ import (
// the original netx implementation and that we cannot remove
// or change without thinking about the consequences.
// See https://github.com/ooni/probe/issues/1985
var errReduceErrorsEmptyList = errors.New("bug: reduceErrors given an empty list")
// quirkReduceErrors finds a known error in a list of errors since
// it's probably most relevant. If this error is not found, just
// return the first error according to this reasoning:
@ -31,7 +34,8 @@ import (
// See TODO(https://github.com/ooni/probe/issues/1779).
func quirkReduceErrors(errorslist []error) error {
if len(errorslist) == 0 {
return nil
// See https://github.com/ooni/probe/issues/1985
return errReduceErrorsEmptyList
}
for _, err := range errorslist {
var wrapper *ErrWrapper