fix(reduceErrors): return error when given an empty list (#675)

See https://github.com/ooni/probe/issues/1985 for context.

While there, ensure nextlite has 100% of coverage.
This commit is contained in:
Simone Basso 2022-01-26 12:18:36 +01:00 committed by GitHub
commit ce8ec5b391
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 18 additions and 3 deletions

View file

@ -439,7 +439,6 @@ func TestHTTPTLSDialerWithReadTimeout(t *testing.T) {
}
func TestNewHTTPTransportStdlib(t *testing.T) {
// What to test about this factory?
txp := NewHTTPTransportStdlib(log.Log)
ctx, cancel := context.WithCancel(context.Background())
cancel() // immediately!
@ -454,6 +453,9 @@ func TestNewHTTPTransportStdlib(t *testing.T) {
if resp != nil {
t.Fatal("unexpected resp")
}
if txp.Network() != "tcp" {
t.Fatal("unexpected .Network return value")
}
txp.CloseIdleConnections()
}