refactor(oohelperd): better distinguish different helpers (#434)

Part of https://github.com/ooni/probe/issues/1733

internal/cmd/oohelperd/internal/webconnectivity/webconnectivity_test.go

@@ -0,0 +1,160 @@
+package webconnectivity
+
+import (
+	"context"
+	"encoding/json"
+	"errors"
+	"net"
+	"net/http"
+	"net/http/httptest"
+	"strings"
+	"testing"
+
+	"github.com/ooni/probe-cli/v3/internal/iox"
+	"github.com/ooni/probe-cli/v3/internal/netxlite"
+)
+
+const simplerequest = `{
+	"http_request": "https://dns.google",
+	"http_request_headers": {
+	  "Accept": [
+		"*/*"
+	  ],
+	  "Accept-Language": [
+		"en-US;q=0.8,en;q=0.5"
+	  ],
+	  "User-Agent": [
+		"Mozilla/5.0"
+	  ]
+	},
+	"tcp_connect": [
+	  "8.8.8.8:443"
+	]
+}`
+
+const requestWithoutDomainName = `{
+	"http_request": "https://8.8.8.8",
+	"http_request_headers": {
+	  "Accept": [
+		"*/*"
+	  ],
+	  "Accept-Language": [
+		"en-US;q=0.8,en;q=0.5"
+	  ],
+	  "User-Agent": [
+		"Mozilla/5.0"
+	  ]
+	},
+	"tcp_connect": [
+	  "8.8.8.8:443"
+	]
+}`
+
+func TestWorkingAsIntended(t *testing.T) {
+	handler := Handler{
+		Client:            http.DefaultClient,
+		Dialer:            new(net.Dialer),
+		MaxAcceptableBody: 1 << 24,
+		Resolver:          &netxlite.ResolverSystem{},
+	}
+	srv := httptest.NewServer(handler)
+	defer srv.Close()
+	type expectationSpec struct {
+		name            string
+		reqMethod       string
+		reqContentType  string
+		reqBody         string
+		respStatusCode  int
+		respContentType string
+		parseBody       bool
+	}
+	expectations := []expectationSpec{{
+		name:           "check for invalid method",
+		reqMethod:      "GET",
+		respStatusCode: 400,
+	}, {
+		name:           "check for invalid content-type",
+		reqMethod:      "POST",
+		respStatusCode: 400,
+	}, {
+		name:           "check for invalid request body",
+		reqMethod:      "POST",
+		reqContentType: "application/json",
+		reqBody:        "{",
+		respStatusCode: 400,
+	}, {
+		name:           "with measurement failure",
+		reqMethod:      "POST",
+		reqContentType: "application/json",
+		reqBody:        `{"http_request": "http://[::1]aaaa"}`,
+		respStatusCode: 400,
+	}, {
+		name:            "with reasonably good request",
+		reqMethod:       "POST",
+		reqContentType:  "application/json",
+		reqBody:         simplerequest,
+		respStatusCode:  200,
+		respContentType: "application/json",
+		parseBody:       true,
+	}, {
+		name:            "when there's no domain name in the request",
+		reqMethod:       "POST",
+		reqContentType:  "application/json",
+		reqBody:         requestWithoutDomainName,
+		respStatusCode:  200,
+		respContentType: "application/json",
+		parseBody:       true,
+	}}
+	for _, expect := range expectations {
+		t.Run(expect.name, func(t *testing.T) {
+			body := strings.NewReader(expect.reqBody)
+			req, err := http.NewRequest(expect.reqMethod, srv.URL, body)
+			if err != nil {
+				t.Fatalf("%s: %+v", expect.name, err)
+			}
+			if expect.reqContentType != "" {
+				req.Header.Add("content-type", expect.reqContentType)
+			}
+			resp, err := http.DefaultClient.Do(req)
+			if err != nil {
+				t.Fatalf("%s: %+v", expect.name, err)
+			}
+			defer resp.Body.Close()
+			if resp.StatusCode != expect.respStatusCode {
+				t.Fatalf("unexpected status code: %+v", resp.StatusCode)
+			}
+			if v := resp.Header.Get("content-type"); v != expect.respContentType {
+				t.Fatalf("unexpected content-type: %s", v)
+			}
+			data, err := iox.ReadAllContext(context.Background(), resp.Body)
+			if err != nil {
+				t.Fatal(err)
+			}
+			if !expect.parseBody {
+				return
+			}
+			var v interface{}
+			if err := json.Unmarshal(data, &v); err != nil {
+				t.Fatal(err)
+			}
+		})
+	}
+}
+
+func TestHandlerWithRequestBodyReadingError(t *testing.T) {
+	expected := errors.New("mocked error")
+	handler := Handler{MaxAcceptableBody: 1 << 24}
+	rw := NewFakeResponseWriter()
+	req := &http.Request{
+		Method: "POST",
+		Header: map[string][]string{
+			"Content-Type":   {"application/json"},
+			"Content-Length": {"2048"},
+		},
+		Body: &FakeBody{Err: expected},
+	}
+	handler.ServeHTTP(rw, req)
+	if rw.StatusCode != 400 {
+		t.Fatal("unexpected status code")
+	}
+}