cleanup: remove ConnID, DialID, TransactionID (#395)

We are not using them anymore. The only nettest still using the
legacy netx implementation is tor, for which setting these fields
is useless, because it performs each measurement into a separate
goroutine. Hence, let us start removing this part of the legacy
netx codebase, which is hampering progress in other areas.

Occurred to me while doing testing for the recent changes in
error mapping (https://github.com/ooni/probe/issues/1505).

internal/engine/netx/resolver/errorwrapper.go

@@ -3,8 +3,6 @@ package resolver
 import (
 	"context"
 
-	"github.com/ooni/probe-cli/v3/internal/engine/legacy/netx/dialid"
-	"github.com/ooni/probe-cli/v3/internal/engine/legacy/netx/transactionid"
 	"github.com/ooni/probe-cli/v3/internal/engine/netx/errorx"
 )
 
@@ -15,15 +13,11 @@ type ErrorWrapperResolver struct {
 
 // LookupHost implements Resolver.LookupHost
 func (r ErrorWrapperResolver) LookupHost(ctx context.Context, hostname string) ([]string, error) {
-	dialID := dialid.ContextDialID(ctx)
-	txID := transactionid.ContextTransactionID(ctx)
 	addrs, err := r.Resolver.LookupHost(ctx, hostname)
 	err = errorx.SafeErrWrapperBuilder{
-		Classifier:    errorx.ClassifyResolveFailure,
-		DialID:        dialID,
-		Error:         err,
-		Operation:     errorx.ResolveOperation,
-		TransactionID: txID,
+		Classifier: errorx.ClassifyResolveFailure,
+		Error:      err,
+		Operation:  errorx.ResolveOperation,
 	}.MaybeBuild()
 	return addrs, err
 }