c/ooni-probe-cli
Watch
1
0
Fork
You've already forked ooni-probe-cli
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor: fully move IDNAResolver to netxlite (#433)

Browse source 
We started doing this in https://github.com/ooni/probe-cli/pull/432.

This work is part of https://github.com/ooni/probe/issues/1733.
This commit is contained in:
Simone Basso 2021-08-17 11:02:12 +02:00 • committed by GitHub
commit bef5b87a8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 84 additions and 120 deletions
Download patch file Download diff file Expand all files Collapse all files

14
internal/engine/netx/netx_test.go
View file

@ -20,7 +20,7 @@ import (
func TestNewResolverVanilla(t *testing.T) {
r := netx.NewResolver(netx.Config{})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -44,7 +44,7 @@ func TestNewResolverSpecificResolver(t *testing.T) {
// not initialized because it doesn't matter in this context
},
})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -66,7 +66,7 @@ func TestNewResolverWithBogonFilter(t *testing.T) {
r := netx.NewResolver(netx.Config{
BogonIsError: true,
})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -92,7 +92,7 @@ func TestNewResolverWithLogging(t *testing.T) {
r := netx.NewResolver(netx.Config{
Logger: log.Log,
})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -122,7 +122,7 @@ func TestNewResolverWithSaver(t *testing.T) {
r := netx.NewResolver(netx.Config{
ResolveSaver: saver,
})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -151,7 +151,7 @@ func TestNewResolverWithReadWriteCache(t *testing.T) {
r := netx.NewResolver(netx.Config{
CacheResolutions: true,
})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}
@ -182,7 +182,7 @@ func TestNewResolverWithPrefilledReadonlyCache(t *testing.T) {
"dns.google.com": {"8.8.8.8"},
},
})
ir, ok := r.(resolver.IDNAResolver)
ir, ok := r.(*resolver.IDNAResolver)
if !ok {
t.Fatal("not the resolver we expected")
}